The-Academic-Observatory / oaebu-workflows

Telescopes, Workflows and Data Services for the 'Book Analytics Dashboard Project (2022-2025)', building upon the project 'Developing a Pilot Data Trust for Open Access eBook Usage (2020-2022)'
https://documentation.book-analytics.org/
Apache License 2.0
5 stars 0 forks source link

Fix issue with OAPEN metadata filter #190

Closed keegansmith21 closed 1 year ago

keegansmith21 commented 1 year ago

This PR addresses a bug with the OAPEN metadata filter (formerly called the parser). The bug would skip over lists, which was a big issue as the main field we want to filter on is the list of products. The tests did not attempt to filter any lists, so this has also been amended. I've also updated the naming convention as I think 'filter' is more apporpriate and sets it apart from the actual parsing step.

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (bd6338f) 95.20% compared to head (59dcd2c) 95.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #190 +/- ## =========================================== - Coverage 95.20% 95.19% -0.01% =========================================== Files 16 16 Lines 2396 2395 -1 Branches 312 313 +1 =========================================== - Hits 2281 2280 -1 Misses 71 71 Partials 44 44 ``` | [Files](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory) | Coverage Δ | | |---|---|---| | [...bu\_workflows/workflows/oapen\_metadata\_telescope.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9vYXBlbl9tZXRhZGF0YV90ZWxlc2NvcGUucHk=) | `97.14% <100.00%> (-0.02%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.