Closed keegansmith21 closed 11 months ago
Attention: 25 lines
in your changes are missing coverage. Please review.
Comparison is base (
f9d26d8
) 93.29% compared to head (a033fea
) 94.27%.:exclamation: Current head a033fea differs from pull request most recent head 44a7263. Consider uploading reports for the commit 44a7263 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
JSTOR has added support for collections of works, as opposed to their normal functioning regime which involves grouping works by publisher.
From a technical perspective, Collection reports are a little different to publisher reports, but they are not different enough (and the metrics they provide are 1:1 comparable) to warrant a new telescope. Instead, I implemented an option for the current JSTOR telecope that makes room for processing a collection. The collection and publisher-unique functionality is contained by their own classes, which each inherit from the JstorAPI class.
Implementation Notes
Data Partners
In the config, the following kwargs should be changed for JSTOR DAGs:
Where:
The jstor_country_collection and jstor_institution_collection data partners were added for the sole purpose of directing the telescope to the correct schema for table upload. The schemas are slightly different, so this was necessary. It is important to note, however, that the ONIX WF should use the original (jstor_country, jstor_institution) data partners regardless. This is because the two are treated as the same in the ONIX WF - the difference in fields is not important as it only processes ISBN usage.
Regex:
The regex that matches on report name is provisional. I only have one example email to base this off so it may change as needed when onboarding future collections.