Closed keegansmith21 closed 11 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
0b1ef28
) 93.18% compared to head (727e53e
) 93.18%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@keegansmith21 - I think I may have missed jstor as well, for the author export table anyway. Comparing with the export_book_metrics.sql.jinja2, should array_length be used instead?
OR ARRAY_LENGTH(month.crossref_events) > 0 OR ARRAY_LENGTH(month.jstor_country) > 0
@keegansmith21 - I think I may have missed jstor as well, for the author export table anyway. Comparing with the export_book_metrics.sql.jinja2, should array_length be used instead?
OR ARRAY_LENGTH(month.crossref_events) > 0 OR ARRAY_LENGTH(month.jstor_country) > 0
@kathrynnapier - Yep jstor condition was also missing for the export tables. I have also changed the conditions to check the array length for crossef and jstor rather than check if they are null.
JIRA ticket
@kathrynnapier noticed that some entries in the export tables were missing. This appears to be because they're missing an IF NOT NULL statement for crossref and GA.