The-Academic-Observatory / observatory-platform

Observatory Platform Package
https://docs.observatory.academy
Apache License 2.0
18 stars 5 forks source link

Feature/Add FTP Server #621

Closed alexmassen-hane closed 1 year ago

alexmassen-hane commented 1 year ago

Need to add a FTP server feature to locally host a directory for anonymous access for use by future workflows and tests. Unable to use the existing SFTP functions as they are different protocols.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 96.77% and project coverage change: -0.01 :warning:

Comparison is base (658705f) 87.73% compared to head (ed74bb4) 87.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #621 +/- ## =========================================== - Coverage 87.73% 87.73% -0.01% =========================================== Files 38 38 Lines 5138 5169 +31 Branches 622 623 +1 =========================================== + Hits 4508 4535 +27 - Misses 498 501 +3 - Partials 132 133 +1 ``` | [Impacted Files](https://app.codecov.io/gh/The-Academic-Observatory/observatory-platform/pull/621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory) | Coverage Δ | | |---|---|---| | [...rm/observatory/platform/observatory\_environment.py](https://app.codecov.io/gh/The-Academic-Observatory/observatory-platform/pull/621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2JzZXJ2YXRvcnktcGxhdGZvcm0vb2JzZXJ2YXRvcnkvcGxhdGZvcm0vb2JzZXJ2YXRvcnlfZW52aXJvbm1lbnQucHk=) | `87.45% <96.77%> (+0.54%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/The-Academic-Observatory/observatory-platform/pull/621/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.