search

The-Academic-Observatory / observatory-platform

Observatory Platform Package
https://docs.observatory.academy
Apache License 2.0
18 stars 5 forks source link

Feature: Add bq functions to the platform #646

Closed alexmassen-hane closed 11 months ago

alexmassen-hane commented 1 year ago

This PR was to originally just to add the function "bq_get_table" to the platform. However, I noticed that there were a few small functions in that were missing some unit tests. I have added the missing small tests for the all the functions bigquery.py.

Please review and edit as necessary.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (44f6e80) 86.99% compared to head (e1db4e6) 87.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #646 +/- ## ========================================== + Coverage 86.99% 87.11% +0.11% ========================================== Files 34 34 Lines 4715 4725 +10 Branches 574 576 +2 ========================================== + Hits 4102 4116 +14 + Misses 482 478 -4 Partials 131 131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jdddog commented 11 months ago

@alexmassen-hane, it would be better to move the functions related to data quality to a different pull request so that changes to them don't block the data quality workflow from being merged. In the new PR, the observatory environment shouldn't be imported to the bigquery module, as it will result in a circular import.