Changing ore rendering from translucent to cutout.

The-Acronym-Coders / BASE

The Central Repo For The B.A.S.E Project

16 stars 13 forks source link

Changing ore rendering from translucent to cutout. #111

Closed legendblade closed 5 years ago

legendblade commented 5 years ago

This fixes some rendering issues where:

The ore shows up in front of rain that should be visible between you and the ore.
Particle effects are visible through the ore
Large walls of ore (e.g. Geolosys/GregTech generation) cause excessive rendering lag and weird artifacting at block edges.

CLAassistant commented 5 years ago

All committers have signed the CLA.

FreneticScribbler commented 5 years ago

Hmm, I suppose I didn't really think that one through. Does that re-break ore shadowing?

legendblade commented 5 years ago

Ah, my apologies, I'd forgotten to test that; it does indeed look like the ore doesn't block light anymore. :(

FreneticScribbler commented 5 years ago

Hang on what. That should have nothing to do with it.... It should block light no matter what. Hmm.

To give more detail on my original question. Our ores have a translucent shadow layer to give them depth, that's why they were set to translucent. Does this still render with cutout set?

legendblade commented 5 years ago

You know, I'd originally typed out a length response in regards to the shadow layer, only to second guess myself and check if they blocked light as well.

To answer that question, no, unfortunately they no longer generate the shadow layer either - though in the pack I was testing this with originally, we removed the shadow layer because it clashed badly with some of the base textures we were using (especially any darker colored blocks - basalt, slate, etc). Upon retesting in a fresh pack this morning with no changes to the shadow layer, it's still missing from the blocks.

Sorry for the misunderstanding.

SkySom commented 5 years ago

The main issue with the shadow wasn't that it wasn't showing up. More that it was white. And looked like hell.

FreneticScribbler commented 5 years ago

Never had an issue with it rendering white, only that it didn't show up at all.

But given the problems with translucent texture implementations, I reckon we ditch the shadow layer altogether.

SkySom commented 5 years ago

Honestly come 1.14, I will be ditching, the issue is with the current already generated jsons, it's got to stay around as removing it now would break any default assets. Honestly if things are an issue for you @legendblade my suggest is adding a part data that can set the ore rendering, so you can switch it for your needs, but not break any current blocks. Feel free to reach out to me in Discord for additional info. I'd love to work through this.

legendblade commented 5 years ago

@SkySom not a problem - I'd generally forgotten about this as Rorax and I have decided to just wait until 1.14 to put the pack out anyway.

Thanks.

SkySom commented 5 years ago

Works for me I'll go ahead and close the PR for now. And we'll see revisit when I move the Material stuff over to 1.14