search

The-Acronym-Coders / BASE

The Central Repo For The B.A.S.E Project
16 stars 13 forks source link

Enable alternative namespaces #114

Closed tpotancok closed 4 years ago

tpotancok commented 4 years ago

This will (hopefully) enable mods (read: ContentTweaker) to use alternative namespaces in the registered ResourceLocation when easy-registering blocks, items or entities. This opens up a world of (I can think of 2) possibilities, like overrides and splitting a large mod into multiple chunks. Also null-safe and completely optional for the modder side. CoT will also get an update PR to take advantage of this.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

SkySom commented 4 years ago

Hey Blaster, first off, this code doesn't even compile, secondly you don't set alternative name anywhere in the registries, so that doesn't work either!

Also I specifically chose to force the ContentTweaker modid into users, so there was no question of where something came from, reducing support confusion.

In the case of wanting to split of "larger" mods along different ids, that'd be extremely simple to do by creating a second BaseModFoundation and going from there, it'd have it's own Registries and such, as well as all of it's own standalone pieces.

This doesn't even go towards the fact that BASE is receiving no further updates in 1.12.

In the future, I encourage you to communicate to the project owners before making PRs! We could have raised these concerns and stopped you wasting your precious time!