The-Acronym-Coders / BASE

The Central Repo For The B.A.S.E Project
16 stars 13 forks source link

BASE hiding custom crafttweaker recipes in JEI? #43

Closed SeriousCreeper closed 7 years ago

SeriousCreeper commented 7 years ago

Heyo,

i noticed recently that the custom recipes i added to the embers melter (and other machines) don't show up in JEI properly when i add BASE to the pack. The recipes i set up still work, but JEI doesn't display them properly. As soon as i disable BASE, it shows up properly again.

Example of what i'm trying:

mods.embers.Melter.remove(<liquid:iron>);
mods.embers.Melter.addOreRecipe(<ore:nuggetIron>, <liquid:iron> * 99, false, false);

Melter is suppose to remove everything iron related and only melt a nugget into 99mB of molten iron. The recipe works, but JEI now shows that a nugget still melts into 16, it also shows the recipe for the ingots and ore blocks (that should be removed).

If i remove BASE, the only recipe i see is the one specified above.

I tried to move my custom recipes into the BASE/scripts folder too, to see if that makes a difference, but doesn't seem to.

If i disable "Materials enabled" in the config, it works properly, but then i don't have any materials of course heh.

Any idea how to fix this?

Possible an issue with embers (@elucent) itself? (Gonna see if i can replicate this with other mod recipes)

EDIT: yeah same happens with tinkers recipes such as this:

mods.tconstruct.Smeltery.addMelting(<liquid:copper> * 99, <embers:nuggetCopper>, 200, <embers:nuggetCopper>);

Thanks, SC

SkySom commented 7 years ago

I'm gonna assume its not Materials, its the Minetweaker module, and how we have to run our scripts early. Try turning that off.

SeriousCreeper commented 7 years ago

Thanks for getting back so quickly!

Tried to disable the Minetweaker module, but didn't make any difference. Also tried the JEI one to check, also no difference.

SkySom commented 7 years ago

Interesting. The Minetweaker one is the only one that actual loads minetweaker. Guess it comes down to mod load order. Interesting. Will remove that in a bit and see if that majes it work for you.

jaredlll08 commented 7 years ago

What JEI, MTLib, Crafttweaker, Modtweaker versions are you running?

On Feb 13, 2017 02:44, "Skylar Sommers" notifications@github.com wrote:

Interesting. The Minetweaker one is the only one that actual loads minetweaker. Guess it comes down to mod load order. Interesting. Will remove that in a bit and see if that majes it work for you.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/The-Acronym-Coders/BASE/issues/43#issuecomment-279270193, or mute the thread https://github.com/notifications/unsubscribe-auth/AFS9xTrd5oV-wONyjEopFk16DhRpyKIMks5rb6eAgaJpZM4L-rk9 .

SeriousCreeper commented 7 years ago

JEI: 3.14.6.408 CT: 3.0.20 MT: 2.0.9 MTLib: 1.0.1

jaredlll08 commented 7 years ago

This may seem like a weird request, but can you remove Base and add initial inventory please, you don't need to add any scripts, I'm just testing a theory

SeriousCreeper commented 7 years ago

Just tried it out, same thing indeed! Recipe is working but not showing up in JEI.

jaredlll08 commented 7 years ago

Could you pass me your minetweaker.log file, and the game log file please

SeriousCreeper commented 7 years ago

Sure, minetweaker.log: http://pastebin.com/Nk6uMQWa fml-client-latest.log: http://pastebin.com/qSe7s0Ze

Let me know if you need a different kind of log or anything.

Thanks, SC

jaredlll08 commented 7 years ago

Do me a favour and try this version http://ci.blamejared.com/job/CraftTweaker-Dev/12/ And I will need the game log and the minetweaker.log file please

SeriousCreeper commented 7 years ago

Unfortunately no difference.

Minetweaker.log: http://pastebin.com/kB5rFRZk client log: http://pastebin.com/r1favpVx

jaredlll08 commented 7 years ago

kk cool, so these shouldn't actually fix anything, it is just giving me more debug info to try and figure this issue out http://ci.blamejared.com/job/CraftTweaker-Dev/13/ I would need the same info please

SeriousCreeper commented 7 years ago

Gotcha!

Minetweaker: http://pastebin.com/tbxFB9S4 Client: http://pastebin.com/mgnbzgCQ

jaredlll08 commented 7 years ago

Ok so, nearly there, this one should give me a lot more info about this issue! http://ci.blamejared.com/job/CraftTweaker-Dev/14/

Sorry for asking you to do all of these >_< I just can't reproduce it on my side :/

SeriousCreeper commented 7 years ago

No problem! Glad to help out, let me know if you need more testing.

Minetweaker: http://pastebin.com/9vWKYzcm Client: http://pastebin.com/NjjaWft0

jaredlll08 commented 7 years ago

Can you update to the latest CrT and try again please

SeriousCreeper commented 7 years ago

Sorry for the late reply, just gave it a try, unfortunately still doesn't show the correct recipe.

Minetweaker; http://pastebin.com/YN9Sfmee Client: http://pastebin.com/6tFJDY40

Let me know if you need more testing!

Cheers, SC

Lanse505 commented 7 years ago

@jaredlll08 ???

jaredlll08 commented 7 years ago

I honestly have no idea on this

On Mar 28, 2017 14:11, "Lanse" notifications@github.com wrote:

@jaredlll08 https://github.com/jaredlll08 ???

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/The-Acronym-Coders/BASE/issues/43#issuecomment-289749530, or mute the thread https://github.com/notifications/unsubscribe-auth/AFS9xSgCXEmYm8Jv0mjWJUiBUS3Lv2sgks5rqPitgaJpZM4L-rk9 .

SkySom commented 7 years ago

Shouldn't be an issue in 1.12 (Can't really figure it out in 1.10 so it just has to be a thing, sorry!)