The-Acronym-Coders / BASE

The Central Repo For The B.A.S.E Project
16 stars 13 forks source link

Block part naming #74

Closed pyure closed 6 years ago

pyure commented 6 years ago

Per discussion with SkySom:

Create a block requires MaterialSystem.getPartType("storage") .

One might logically expect MaterialSystem.getPartType("block") here (notwithstanding that it kinda visually conflicts with something like metal.registerPart("block"), not really a problem. )

Connected, you identified this as a concern: var machineFrame = MaterialSystem.getPartBuilder().setName("machine_frame") vs var machineFrame = MaterialSystem.getPartBuilder().setName("Machine Frame")

SkySom commented 6 years ago

Fixed by: https://github.com/The-Acronym-Coders/BASE/commit/1c633105e5f381a3031a7f278a7f4648cc339a5d