search

The-Acronym-Coders / BASE

The Central Repo For The B.A.S.E Project
16 stars 13 forks source link

Crash when attempting to drop invalid item #95

Closed Gegy closed 6 years ago

Gegy commented 6 years ago

From: https://github.com/gegy1000/PracticalSpaceFireworks/issues/5

When an invalid item is specified, this code prints an error, but allows the code to continue: https://github.com/The-Acronym-Coders/BASE/blob/0244cd5c37a47dab9efdd6778be2f9e4c80fc165/src/main/java/com/teamacronymcoders/base/materialsystem/blocks/SubBlockOrePart.java#L60-L64

Leaving this code to crash, as isValid does not check for null: https://github.com/The-Acronym-Coders/BASE/blob/0244cd5c37a47dab9efdd6778be2f9e4c80fc165/src/main/java/com/teamacronymcoders/base/materialsystem/blocks/SubBlockOrePart.java#L70-L74

FreneticScribbler commented 6 years ago

I think https://github.com/Brian-Wuest/MC-Prefab/issues/84 is the same issue?

SkySom commented 6 years ago

It is most likely, yes