The-Acronym-Coders / O.R.E

The Central Repo For The O.R.E Project
4 stars 2 forks source link

[Issue]: World Generation Issues - Related to Cluster Gen #3

Open demethan opened 8 years ago

demethan commented 8 years ago

Not really an issu but more of a cry for help. I tried reaching someone on Discord.

We copied your exemples and we cannot make it work correctly.

All the ore spawns in the air. 2016-10-04_21 54 09

here is our pack's json file. maybe you see something I don't. Many thanks.

https://github.com/BreakfastCraft/BreakfastSpecial/blob/master/Config/ORE/Generators/special.json

Forge 2094 BASE on 1.10-18, ORE on 1.0.3-1.10.2

AngelCry commented 8 years ago

same here (kinda confirm). i have feel like something wrong with "replaceable" setting , so is spawn ores in air even if there no "air" in replaceable and with height setting (at least "maxHeight"), so as example i have redstone spawned at same height as iron, while i have "minHeight": 0, "maxHeight": 16 for it. at current state this mod looks unusable :(

Lanse505 commented 8 years ago

Currently the mod and generators are still in-alpha, from the looks of it you're using the Cluster-gen which is the one which is under the most need of work atm. I'd recommend switching to the Vein generators instead for now until we can get it fixed up.

Also I did answer you on discord with: Simon (Lanse505) - Today at 9:08 AM @Demethan Yes, It's on the ORE Wiki page on our Github @Demethan Can I see your Json?

Me and Jared are doing our best atm to fix these issue so keep them coming, but at the current moment do expect slow patches due to Jared being on his final year of High-School and Me being stuck with Uni assignments (hopefully at the end of the month we'll be able to pick-up the slack again and push more frequent updates)

Lanse505 commented 8 years ago
        "replaceable": [
            "minecraft:dirt",
            "minecraft:stone",
            "minecraft:gravel",
            "chisel"
        ],

You need to define WHAT in chisel it's supposte to replace, you can't just do a empty "chisel" line.

  1. Acctually I just noticed from reading through this, I've already pointed out all the issues with the Json to Topther on Discord a few days ago. For example:
        "blocks": {
            "substratum:ore": 3
        },

Are on tooooo many lines, you need to add a meta and they way you properly implement this is;

        "blocks": {
            "substratum:ore;meta": 3
        },

aka

        "blocks": {
            "substratum:ore;3": 1
        },

also the ": number" after the block thingy is a weight stat not metadata.

Lanse505 commented 8 years ago

Also Jared says

Please try and use the "ore" generator instead.
It requires no params so leave the params field empty like this:
        "params": {},
AngelCry commented 8 years ago

I'd recommend switching to the Vein generators instead for now i forgot mention it earlier, but i used Vein, not Cluster. also, my json do not have "chisel", only "minecraft:stone", "minecraft:dirt", "minecraft:gravel" and still get ore generated everywhere - in ground, in water, in air. actually i just copied "Vein" section from example ("Test1"), pasted it few times, removed "air" from "replaceable" and tweak "height" a bit for few vanilla ores - iron, coal, redstone, gold.

jaredlll08 commented 8 years ago

I need your game log please.

demethan commented 8 years ago

First I'd like to say thanks and second I understand we all have real life stuff. When I said I couldn't reach anyone on discord, it wasn`t a reprimande, just a fact. I appologize if it offended you and you felt you had to make excuses. No excuses needed.. I completly understand.

Thanks for the pointers. I ll try to clean up the JSON file and see where it gets me. I wasn`t aware of the exact details Topher received.

Jaredlll08, do you need my logs or AngelCry`s?

jaredlll08 commented 8 years ago

Both

On Oct 5, 2016 3:02 PM, "Demethan" notifications@github.com wrote:

First I'd like to say thanks and second I understand we all have real life stuff. When I said I couldnt reach anyone on discord, it wasnt a reprimande, just a fact. I appologize if it offended you and you felt you had to make excuses. No excuses needed.. I completly understand.

Thanks for the pointers. I ll try to clean up the JSON file and see where it gets me. I wasn`t aware of the exact details Topher received.

Jaredlll08, do you need my logs or AngelCry`s?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/The-Acronym-Coders/O.R.E/issues/3#issuecomment-251667441, or mute the thread https://github.com/notifications/unsubscribe-auth/AFS9xfbVv2_gfQ1BUhyvZQNklUSn9ASEks5qw5-fgaJpZM4KOW5m .

AngelCry commented 8 years ago

i think you talk about this part:

[06:40:58] [Client thread/INFO]: Pre-Initialization started
[06:40:58] [Client thread/INFO]: class com.acronym.ore.api.generation.Generation
[06:40:58] [Client thread/INFO]: Generation{name='IronVein', type='vein', params={sparse=false}, worldGenerator=null, blocks={minecraft:iron_ore=1}, genTries='1', blockCount='150', minHeight='0', maxHeight='80', replaceable=[minecraft:stone, minecraft:dirt, minecraft:gravel], chunkChance='20', biomeRestriction='none', biomes=[], dimensionsRestriction='none', dimensions=[]}
[06:40:58] [Client thread/INFO]: class com.acronym.ore.api.generation.Generation
[06:40:58] [Client thread/INFO]: Generation{name='GoldVein', type='vein', params={sparse=false}, worldGenerator=null, blocks={minecraft:gold_ore=1}, genTries='1', blockCount='80', minHeight='0', maxHeight='32', replaceable=[minecraft:stone, minecraft:dirt, minecraft:gravel], chunkChance='20', biomeRestriction='none', biomes=[], dimensionsRestriction='none', dimensions=[]}
[06:40:58] [Client thread/INFO]: class com.acronym.ore.api.generation.Generation
[06:40:58] [Client thread/INFO]: Generation{name='RedstoneVein', type='vein', params={sparse=false}, worldGenerator=null, blocks={minecraft:redstone_ore=1}, genTries='1', blockCount='60', minHeight='0', maxHeight='16', replaceable=[minecraft:stone, minecraft:dirt, minecraft:gravel], chunkChance='20', biomeRestriction='none', biomes=[], dimensionsRestriction='none', dimensions=[]}
[06:40:58] [Client thread/INFO]: class com.acronym.ore.api.generation.Generation
[06:40:58] [Client thread/INFO]: Generation{name='CoalVein', type='vein', params={sparse=false}, worldGenerator=null, blocks={minecraft:redstone_ore=1}, genTries='1', blockCount='120', minHeight='0', maxHeight='80', replaceable=[minecraft:stone, minecraft:dirt, minecraft:gravel], chunkChance='20', biomeRestriction='none', biomes=[], dimensionsRestriction='none', dimensions=[]}
[06:40:58] [Client thread/INFO]: adding type: Generation{name='IronVein', type='vein', params={sparse=false}, worldGenerator=null, blocks={minecraft:iron_ore=1}, genTries='1', blockCount='150', minHeight='0', maxHeight='80', replaceable=[minecraft:stone, minecraft:dirt, minecraft:gravel], chunkChance='20', biomeRestriction='none', biomes=[], dimensionsRestriction='none', dimensions=[]}
[06:40:58] [Client thread/INFO]: addingIronVein
[06:40:58] [Client thread/INFO]: adding type: Generation{name='GoldVein', type='vein', params={sparse=false}, worldGenerator=null, blocks={minecraft:gold_ore=1}, genTries='1', blockCount='80', minHeight='0', maxHeight='32', replaceable=[minecraft:stone, minecraft:dirt, minecraft:gravel], chunkChance='20', biomeRestriction='none', biomes=[], dimensionsRestriction='none', dimensions=[]}
[06:40:58] [Client thread/INFO]: addingGoldVein
[06:40:58] [Client thread/INFO]: adding type: Generation{name='RedstoneVein', type='vein', params={sparse=false}, worldGenerator=null, blocks={minecraft:redstone_ore=1}, genTries='1', blockCount='60', minHeight='0', maxHeight='16', replaceable=[minecraft:stone, minecraft:dirt, minecraft:gravel], chunkChance='20', biomeRestriction='none', biomes=[], dimensionsRestriction='none', dimensions=[]}
[06:40:58] [Client thread/INFO]: addingRedstoneVein
[06:40:58] [Client thread/INFO]: adding type: Generation{name='CoalVein', type='vein', params={sparse=false}, worldGenerator=null, blocks={minecraft:redstone_ore=1}, genTries='1', blockCount='120', minHeight='0', maxHeight='80', replaceable=[minecraft:stone, minecraft:dirt, minecraft:gravel], chunkChance='20', biomeRestriction='none', biomes=[], dimensionsRestriction='none', dimensions=[]}
[06:40:58] [Client thread/INFO]: addingCoalVein
[06:40:58] [Client thread/INFO]: Pre-Initialization finished after 49ms

(i know, there redstone in coal generator, i changed it later but cant find this log - too many restarts while testing...)

Lanse505 commented 8 years ago

@AngelCry can we get your Json file so we can test it out and help troubleshoot? @demethan Nah, man it's ok :P was just making it clear that the mod is in open alpha and does have alot of issues, and we are working to fix them. But don't expect lightning fast patches everytime smth breaks. We are human too disregarding out stupidly insane sleep scheduels.

topher2010 commented 8 years ago

Lanse, i apologize, i just realized i gave Demethan the wrong json file to work with (OR i forgot to update it on the github for the modpack). I did add in the metadata, and i still had no luck working with it (i will replicate tonight and give logs when i get home from work). However, Jared did mention when i first brought it up in Discord to not add in metadata ":", maybe i misunderstood. I have tried removing ":" from the stone line, as well as removing the chisel line completely, and still had no mod ores generating.

Again, this will be tested after work tonight and FML_Latest logs provided.

BTW, i do have to say i love the idea of BASE and ORE, and can't wait to use it to its full potential.

jaredlll08 commented 8 years ago

Having a super high blockcount will have some adverse effects, @AngelCry reduce your blockcount to something like 1-20 please

Lanse505 commented 8 years ago

@topher2010 "modid:blockid;metadata" : Chance ^ Unless I'm wrong @jaredlll08

jaredlll08 commented 8 years ago

nah thats right @Lanse505

topher2010 commented 8 years ago

ok, i completely misunderstood what you were saying in discord then. I have to apologize for my complete derpness in this. This will be tested thoroughly tonight and github updated by either myself, Demethan, or both. Thanks for the patience regarding this.

Lanse505 commented 8 years ago

@topher2010 it's fine man :P tbh it might also be a issue on our side. As previously stated, ORE is in a pretty heavy alpha state :P but we'll work to fix this now when we've gotten BASE into a stable state :P

topher2010 commented 8 years ago

And i knew it was heavy alpha going in. I promise this isn't a complaint, just want to help along the idea of this.

Lanse505 commented 8 years ago

@topher2010 Don't worry bout it -says it in a very thick italian accent-

topher2010 commented 8 years ago

@Lanse505 that only works if you are at least a New Yorker :P

Lanse505 commented 8 years ago

In that case "ARHAAHGAHGAHAH" Since I'm Swedish and we have Berserkers and Vikings :P haha

topher2010 commented 8 years ago

Even better. Vikings are much better imho. hahaha.