search

The-Aether-Team / The-Aether-Archived

The original "The Aether" mod, ported to the 1.7.10 and 1.12.2 versions of Minecraft. Currently unmaintained; accepting PRs.
https://www.curseforge.com/minecraft/mc-mods/the-aether
GNU Lesser General Public License v3.0
33 stars 28 forks source link

Aerogel stairs planes are culled when they shouldn't be #112

Open muzikbike opened 3 years ago

muzikbike commented 3 years ago

They aren't culled when a full block occludes them, but apparently another stair that doesn't fully occlude said face is fair game...

2021-03-04_23 19 32 2021-03-04_23 19 34

muzikbike commented 3 years ago

(The following screenshots are taken with the fix for #111 applied, however these cases still manifest without it applied and the presence of the fix has absolutely no bearing on it)

Stairs do cull correctly if arranged in an expected manner like as follows: 2021-03-04_23 29 47 2021-03-04_23 32 21

And this bug does not affect normal opaque stairs: 2021-03-04_23 30 11

So this bug must be linked explicitly to how the aether chooses to render translucent stairs. The models themselves are not fully responsible for this (while the models could be changed to remove all cullface parameters, this would result in ugly borders between stair blocks, which this culling was likely implemented to explicitly remove). It may also be the reason why translucent stairs outright ignore cullface for every single other occluding block: 2021-03-04_23 28 54 2021-03-04_23 28 59

From 1.13 onwards, this special culling code may no longer be necessary, as there are some vanilla cases which were fixed in said update (e.g. repeaters not culling the side faces of other repeaters in 1.12.2, which 1.13 fixes), so the 1.16 port might not need any extra code for this.

muzikbike commented 3 years ago

This is absent in the 1.16 version.