The-Aether-Team / The-Aether-Archived

The original "The Aether" mod, ported to the 1.7.10 and 1.12.2 versions of Minecraft. Currently unmaintained; accepting PRs.
https://www.curseforge.com/minecraft/mc-mods/the-aether
GNU Lesser General Public License v3.0
33 stars 28 forks source link

1.12.2 - Aerogel creation can crash. When done automatically by a machine, can crashloop servers #155

Closed Delfayne closed 10 months ago

Delfayne commented 2 years ago

Easy test. Set up an ExU2 Mechanical User with a bucket of lava, crash. If the User is set to loop, this will crash the server as soon as it starts up again.

As far as I can tell, this seems to be caused by the check in AetherEventHandler. There's a code block where Air is checked for, but outside of this block the event is marked as successful. This looks to try creating aerogel even when the destination block is not air, leading to the crash.

I've been running locally with this fix for a while with no further issue.

I understand this project is archived, as are most 1.12 code bases. But if you're still willing to make a release I will post the fix here. this is used in a currently active pack, Divine Journey 2, and is a useful automation there so it's still being used.