search

The-Aether-Team / The-Aether-Archived

The original "The Aether" mod, ported to the 1.7.10 and 1.12.2 versions of Minecraft. Currently unmaintained; accepting PRs.
https://www.curseforge.com/minecraft/mc-mods/the-aether
GNU Lesser General Public License v3.0
33 stars 28 forks source link

Fix Aether parachutes causing permanent crash 🪂 #165

Closed Richard-Rogalski closed 1 month ago

Richard-Rogalski commented 4 months ago

After the player falls out of the Aether dimension with a parachute equipped, when re-entering the Aether the parachute is still there and due to being marked as being mounted with the player, causes a crash preventing the Aether from being entered again.

This commit causes parachutes to despawn when they get below y=0, and also lowers the height in which the player will 'fall out of' the Aether. (gives the parachute more time to despawn and also it's really annoying flying in creative falling at y<-2)

Code from Departure, I'm just the git gremlin

I agree to the Contributor License Agreement (CLA).

AetherLegacyPro commented 4 months ago

The reason above is not correct, this occurred when the player fell out of the aether leaving the parachute entity as they are dismounted from it there without despawning it, upon return it was still there and the game did not know how to handle it's AI but it also immediately despawns it but the AI issue still causes a crash to desktop on client/server.

It hard crashed the client and server but be fine when you reloaded as it would of despawned.

This is my best understanding to why the crash occurred.