The-Aether-Team / The-Aether

The original "The Aether" mod, rewritten and ported to modern Minecraft versions.
https://modrinth.com/mod/aether
GNU Lesser General Public License v3.0
358 stars 116 forks source link

Bug: <title> #1479

Closed Devilswarchild closed 1 year ago

Devilswarchild commented 1 year ago

What Feature Types Apply to This Bug?

Other (Please Describe)

Other Type

Networking issue

What Type of Bug Is This?

Unexpected Behavior

Forge Version

45.0.57

The Aether Version

1.0.0- beta 1, beta2, beta 3 and beta 4

Is This Bug a Conflict With Another Mod?

No response

Client Log

https://gist.github.com/Devilswarchild/eef0ed80234c94fe5ada01808f766b10

Crash Report (if applicable)

No response

Steps to Reproduce

just when trying to join a server or even hosting a multiplayer sessions though lan

What You Expect To Happen

ability to connect to a server like normal

What Actually Happened

Connection Lost Internal Exception: io.netty.handler.codec.DecoderException: javalang.IndexOutOfBoundsException: readerIndex(12) + length(1) exceeds writerIndex(12): PooledUnsafeDirectByteBuf(ridx: 12, widx: 12, cap: 12)

Additional Details

Screenshot_1

modlist:

Croptopia (by thethonk) MidnightLib (by TeamMidnightDust) AttributeFix (by DarkhaxDev) Endless Biomes (by MadoctheHadoc) BlockUI (by Raycoms) Mo' Glowstone Lamps (by TheMasterGeneral) YUNG's Better Mineshafts (Forge) (by YUNGNICKYOUNG) Collective (by Serilum) Many More Advancements (by Krzychowskyyyy) The Twilight Forest (by Benimatic) Fantasy's Furniture (by ApexMdr) MVS - Moog's Voyager Structures (by finndog_123) Storage Racks (by Raycoms) Almost Unified (by AlmostReliable) CTD Core (by TheMasterGeneral) Immersive Weapons (by AnonymousHacker1279) Infused Foods (by ApexMdr) AppleSkin (by squeek502) Reap Mod (by henkelmax) Farsight [Forge] (by someaddon) Domum Ornamentum (by OrionOnline) GravelMiner (by BlayTheNinth) Bad Wither No Cookie - Reloaded (by Kreezxil) The Aether (by TheAetherTeam) Waystones (by BlayTheNinth) YUNG's Better Nether Fortresses (Forge) (by YUNGNICKYOUNG) Corail Pillar (by Corail_31) Security Craft (by Geforce132) Immersive structures (by ChoiceTheorem) Vanilla Plus Tools (by Raycoms) Immersive Structures II: Nether edition (by ChoiceTheorem) Citadel (by sbom_xela) Oreberries Replanted (by Mrbysco) Just Enough Items (JEI) (by mezz) TieFix (by j_t_a_i) Unseen World (by sashakyotoz) Skin Layers 3D (Fabric/Forge) (by tr7zw) Better Fps - Render Distance[Forge] (by someaddon) Structure Essentials[Forge/Fabric] (by someaddon) Borderless Window (by nekeras) SuperMartijn642's Config Lib (by SuperMartijn642) Rubidium (by Asek3) Additional Lanterns (by SuperMartijn642) Better Villages - Forge (by jtl_elisa) playerAnimator (by KosmX)

Aquaculture 2 (by Shadow) Creeper Firework (by DragonsPlus) Savage Ender Dragon[Forge/Fabric] (by someaddon) Immersive Aircraft [Fabric/Forge] (by Conczin) Biomes O' Plenty (by Forstride)

Catalogue (by MrCrayfish) Jade 🔍 (by Snownee_) Cristel Lib (by Cristelknight) AmbientSounds 5 (by CreativeMD) Clumps (by Jaredlll08) Macaw's Paths and Pavings (by sketch_macaw) FPS Monitor (by EwyBoy) Get It Together, Drops! (by bl4ckscor3) Ultris: Boss Expansion (by limesplatus) Ad Astra (by AlexNijjar) FerriteCore (Forge) (by malte0811) FLIB (by Lothrazar) Comforts (Fabric/Forge/Quilt) (by TheIllusiveC4) Balm (Forge Edition) (by BlayTheNinth) Sound Physics Remastered (by henkelmax) MineColonies (by Raycoms) TerraBlender (Forge) (by TheAdubbz) Advancement Plaques [Forge] (by Grend_G) Ender Mail (by Chaosyr) Cosmetic Armor Reworked (by LainMI) YUNG's Extras (Forge) (by YUNGNICKYOUNG) JourneyMap (by techbrew) Packed Up (Backpacks) (by SuperMartijn642) ESSENTIAL Mod (by SparkUniverse_) Corail Woodcutter (by Corail_31) The Undergarden (by Quek04) Not Enough Crashes (Forge) (by NatanFudge) Library Ferret - Forge (by jtl_elisa) Multi-Piston (by Raycoms) Bookshelf (by DarkhaxDev) Iceberg [Forge] (by Grend_G) ForgeEndertech (by EnderLanky) Better Combat [Fabric & Forge] (by daedelus_dev) Structurize (by Raycoms) Stylecolonies (by Raycoms) Large Ore Deposits (by EnderLanky) Oculus (by Asek3) Forbidden and Arcanus (by cesar_zorak) Physics Mod (by haubna) Game Menu Mod Option [Forge] (by morimori0317) Neat (by Vazkii) Cooking for Blockheads (by BlayTheNinth) TrashSlot (by BlayTheNinth) L_Ender 's Cataclysm (by mcl_ender) Transparent (by Trikzon) YUNG's API (Forge) (by YUNGNICKYOUNG) Eccentric Tome (by EccentricVamp) Configured (by MrCrayfish) Inventory Essentials (by BlayTheNinth) When Dungeons Arise - Forge! (by Aureljz) Fast Portals (by gluegunner4) Portable Crafting Table (by 00theblackwolf00) Valhelsia Core (by ValhelsiaTeam) Server Performance - Smooth Chunk Save[Forge/Fabric] (by someaddon) Immersive Paintings [Fabric/Forge] (by Conczin) Enchantment Descriptions (by DarkhaxDev) Corpse (by henkelmax) Unstructured [Fabric/Forge] (by Cristelknight) Double Doors (by Serilum) SuperMartijn642's Core Lib (by SuperMartijn642) The Lost Cities (by McJty) CreativeCore (by CreativeMD) The One Probe (by McJty) Rapid Leaf Decay (by GeheimagentNr1) Advent of Ascension (Nevermine) (by Scimiguy) currently disabled Macaw's Trapdoors (by sketch_macaw) Immersive Armors [Fabric/Forge] (by Conczin) currently disabled Mo' Glowstone (by TheMasterGeneral) Exotelcraft (by TKD_Kedis) Ash API (by Trikzon) Botarium (by CodexAdrian) Chisels & Bits - For Forge (by AlgorithmX2) Resourceful Lib (by ThatGravyBoat) KleeSlabs (by BlayTheNinth) Clickable advancements[Forge/Fabric] (by someaddon) Additional Banners (by DarkhaxDev) Biome Music[Forge/Fabric] (by someaddon) Resourceful Config (by ThatGravyBoat) Why stacks of 16? (by LaidBackSloth42) Architectury API (Fabric/Forge) (by shedaniel) YUNG's Better Dungeons (Forge) (by YUNGNICKYOUNG) Enhanced Farming (by Mrbysco) Wormhole (Portals) (by SuperMartijn642) Just Another Rotten Flesh to Leather Mod (by alexdaum1) Macaw's Doors (by sketch_macaw) Immersive Weapons Compatibility Bridge (by AnonymousHacker1279) currently disabled Cloth Config API (Fabric/Forge) (by shedaniel) Saturn (by AbdElAziz333) Structure Gel API (by ModdingLegacy) YUNG's Better Ocean Monuments (Forge) (by YUNGNICKYOUNG) Entity Culling Fabric/Forge (by tr7zw) Blue Skies (by ModdingLegacy) currently disabled Ad Astra!: Giselle Addon (by 지젤쟝다) PlayerRevive (by CreativeMD) Re-chiseled (by SuperMartijn642) Macaw's Fences and Walls (by sketch_macaw) Towns and Towers (by Biban_Auriu) GeckoLib (by Gecko)

Please Read and Confirm The Following

bconlon1 commented 1 year ago

Does everything work fine without Aether included? Also please do not list every beta version as your version, I need to know what specific version is being used by the clients and server.

Devilswarchild commented 1 year ago

reason I listed them all is cause after each launch and connection test, I downgraded it starting with the latest which is beta 4 just to show that the issue persisted through all the updates. and yes everything works just fine with the aether disabled.

bconlon1 commented 1 year ago

Have you also tried testing removing other mods but not Aether?

Devilswarchild commented 1 year ago

I have actually removed a couple others due to them causing weird log spam type issues and reported one of them to their respective mod author, others caused various exit codes 1 and -1 respective. those are all either downgraded to working versions or disabled altogether until a fix can be implemented into a future update.

Devilswarchild commented 1 year ago

i will now commence a minimal instance test

bconlon1 commented 1 year ago

I mean have you narrowed down confirming whether this issue is just caused by Aether or if it's caused by an interaction between the Aether and a specific other mod by removing mods until either the error went away or the only mod left was the Aether?

Devilswarchild commented 1 year ago

im now running the test with just essentials mod, jade, jei, neat, the one probe and the aether enabled.

Devilswarchild commented 1 year ago

with just those enabled, issue still occured. now proceeding to remove essential and see what happens

Devilswarchild commented 1 year ago

error occured again, now removing neat

Devilswarchild commented 1 year ago

and the error continues, now removing the one probe

Devilswarchild commented 1 year ago

now removing jade as the error occured once more

Cinex20 commented 1 year ago

Why have Structure Gel enabled if you disabled Blue Skies?

Devilswarchild commented 1 year ago

now its just the aether by itself

bconlon1 commented 1 year ago

Could you now please provide the logs from both the server during the time of join and the client during the time of join when this error occurs?

Devilswarchild commented 1 year ago

I dont have access to this particular servers logs at all. seeing as the address for it is literally test.prisonfun.com which I can connect to just fine without the aether as from Ive gather all over the web is just basically a connection test server in which a lot of people just like to horse around on

Burning-Cactus commented 1 year ago

I'm just gonna chime in and say that this is usually caused by a different mod version being used between the client and server. The game is confused because things aren't matching up.

bconlon1 commented 1 year ago

Which sounds like it is the case if you are trying to join a server that doesn't even have the mod installed.

Devilswarchild commented 1 year ago

I'm just gonna chime in and say that this is usually caused by a different mod version being used between the client and server. The game is confused because things aren't matching up.

well this particular server will allow modded clients to login but forces the mods to a disabled state

Burning-Cactus commented 1 year ago

That's simply not how it works. Forge still has mods loaded on your client, so the game's code, registered items and entities, and etc. will all be different. The server can NOT ever change the code on your machine.

Devilswarchild commented 1 year ago

That's simply not how it works. Forge still has mods loaded on your client, so the game's code, registered items and entities, and etc. will all be different. The server can NOT ever change the code on your machine.

nevertheless i am still abled to connect to the server with the aether disabled.

also here are the logs for just the ather enabled

https://gist.github.com/Devilswarchild/ea416928256609d5699a085b5479dbe4

bconlon1 commented 1 year ago

Have you actually tried to test joining a server that has the Aether, with the Aether mod?

Devilswarchild commented 1 year ago

no I haven't actually cause I dont currently know of one, due to the fact that my modpack contains the essential mod which kinda negates the need for a dedicated server

bconlon1 commented 1 year ago

Then have you tried hosting with the Essential mod, with only Aether installed?

Devilswarchild commented 1 year ago

yes, same issue

bconlon1 commented 1 year ago

Then could you give the logs of the Essential "server" (the host), and the client trying to join that is getting the error?

Devilswarchild commented 1 year ago

the essential mod doesnt generate any logs to my knowledge

Devilswarchild commented 1 year ago

but let me double check that

Devilswarchild commented 1 year ago

nope, no logs in its folder

bconlon1 commented 1 year ago

The Essential mod should be hosting from your client, and the client always generates logs.

Devilswarchild commented 1 year ago

yes, and I have provided you with all the logs that I can generate. but ill run it again with the aether and essential as the only enabled mods gimme just a few minutes

bconlon1 commented 1 year ago

Yes, and the previous logs you provided me had 100 other mods installed. Please provide me the logs but without those mods and only the Aether.

Devilswarchild commented 1 year ago

That's simply not how it works. Forge still has mods loaded on your client, so the game's code, registered items and entities, and etc. will all be different. The server can NOT ever change the code on your machine.

nevertheless i am still abled to connect to the server with the aether disabled.

also here are the logs for just the ather enabled

https://gist.github.com/Devilswarchild/ea416928256609d5699a085b5479dbe4

the link above is with just the aether

bconlon1 commented 1 year ago

That is only the logs from one end of the connection. I already said I need logs from both ends of the connection.

Devilswarchild commented 1 year ago

well I can't give you the other end of the connection because I don't have anyone to help me with this. Im a modpack creator who is doing all of this solo

bconlon1 commented 1 year ago

Then where did the connection error you gave in the post come from?

Devilswarchild commented 1 year ago

test.prisonfun.com is the server address I use to test network related issues with my modpack. that address was obtained from several troubleshooting guides across the web which has been very reliable to detect networking issues. and all the issues I've ever had with my modpack have all been the same exact error across all the mc versions of my modpack. I dont not own or have access to any of the files associated with the server.

bconlon1 commented 1 year ago

yes, same issue

Then how did you receive the same connection error from Essential if you only tried ever joining this server?

Devilswarchild commented 1 year ago

I was simply referring to the fact that essential does ,if I can word this correctly in a way that'll help with the understanding it of it, is replaces/improves the open to lan feature by making the "host" pc act as a dedicated server without the actual need of a dedicated server if that makes any sense

bconlon1 commented 1 year ago

I know that, that doesn't answer my question though.

Devilswarchild commented 1 year ago

however, if the test server I connect to is throwing the io.netty.handler error then either me or if I manage to get someoone to connect to would also throw the same error due to it being a multiplayer connection

bconlon1 commented 1 year ago

That is because, as stated before, the connection server does not have Aether installed.

Devilswarchild commented 1 year ago

and I also tried upgrading forge from .57 to .66 and the same issue occurs there which leads me to believe that, hear me out, its quite possible that a line of code could have gotten overlooked or possibly had a typo but what do I know. Im not a coder

Devilswarchild commented 1 year ago

That is because, as stated before, the connection server does not have Aether installed.

i can assure that isnt the case because an earlier version of my modpack also has the aether installed and the server didnt and I was able to connect just fine

Devilswarchild commented 1 year ago

and by earlier version, I mean of course a version of my modpack on an earlier version of minecraft

bconlon1 commented 1 year ago

Not all mods are guaranteed to be able to connect with vanilla servers, because its a vanilla server. It cannot account for every change a mod makes which may make them incompatible. I don't even understand at this point why it matters whether you can connect to this vanilla server or not with your modpack.

Devilswarchild commented 1 year ago

bc If I cant connect to this test server then none of the players using this version of my modpack are going to be able to connect with their friends. (if any of them have any)

bconlon1 commented 1 year ago

And how are you sure of this if you have not tested joining a server that has the modpack on it with a client that has the modpack?

Devilswarchild commented 1 year ago

bc the only person I could potentially try to have help me with this is currently engaged in other activities and wont be available for quite some time

Devilswarchild commented 1 year ago

like an undisclosed amount of time

Devilswarchild commented 1 year ago

ergo I dont know if or when they will be available.