The-Aether-Team / The-Aether

The original "The Aether" mod, rewritten and ported to modern Minecraft versions.
https://modrinth.com/mod/aether
GNU Lesser General Public License v3.0
358 stars 116 forks source link

Bug: Game Crashes #1846

Closed YejiYeah closed 11 months ago

YejiYeah commented 11 months ago

What Feature Types Apply to This Bug?

No response

Other Type

The game crashes: "soundInstance" is null

What Type of Bug Is This?

None

Forge Version

47.2.0

The Aether Version

1.0.0 beta 1.4

Is This Bug a Conflict With Another Mod?

I have removed all the mods related to "sounds" and fancy menu and it keeps crashing, there are more mods in the modpack: Yes Nicer Minecraft 1.1.6: https://www.curseforge.com/minecraft/modpacks/yes-nicer-mc-forge-1

Client Log

https://gist.github.com/SaraXianLin/9af35d607db327a7be35f113799e2c9b

Crash Report (if applicable)

https://gist.github.com/SaraXianLin/079d19f4ce4e43dac6274a4fc04358d9

Steps to Reproduce

Reproduce the crash:

  1. Create a new world in the YNM modpack
  2. Create the portal and go inside
  3. the game crashes while in the Aether

What You Expect To Happen

I hope it stop crashing

What Actually Happened

This happens everytime, when I join the Aether in the next 1 -4 min even I walk or just stay near the portal.

Additional Details

No response

Please Read and Confirm The Following

bconlon1 commented 11 months ago

I think this is an issue with Team Midnight Dust's Visual Overhaul mod, they should be checking if soundInstance != null here: https://github.com/TeamMidnightDust/VisualOverhaul/blob/e9539ba28fa60f023ff910480bbce31ec79de19b/common/src/main/java/eu/midnightdust/visualoverhaul/mixin/MixinSoundSystem.java#L23C1-L26C10