The-Aether-Team / The-Aether

The original "The Aether" mod, rewritten and ported to modern Minecraft versions.
https://modrinth.com/mod/aether
GNU Lesser General Public License v3.0
328 stars 109 forks source link

Bug: two background musics playing simultaneously #1921

Open nu290 opened 6 months ago

nu290 commented 6 months ago

What Feature Types Apply to This Bug?

Audio

Other Type

No response

What Type of Bug Is This?

Annoyance

Forge Version

47.2.0

The Aether Version

1.20.1-1.0.0-neoforge

Is This Bug a Conflict With Another Mod?

Suspected: Music Manager 1.3.13(Neo)Forge 1.20

Client Log

No response

Crash Report (if applicable)

No response

Steps to Reproduce

it happens once in about 5 music pieces, spontaneously as long as the player is in the aether

What You Expect To Happen

one music plays until it ends, then another music plays after a few seconds as set by the music manager

What Actually Happened

while one music is playing and has not ended, another music starts playing to overlap with the first music

Additional Details

i suspect the music files metadata to specify wrong durations

Please Read and Confirm The Following

nu290 commented 6 months ago

i would like to add that just as often, a music piece abruptly stops and another starts playing. i suspect this to be related

Builderdog841 commented 6 months ago

From my experience this isn't a conflict and also happened to me with only the base mod installed. It seems to only happen when the player enters a different biome.

bconlon1 commented 5 months ago

Is this in creative or survival mode?

bconlon1 commented 5 months ago

Also have you tweaked any config variables from the Aether or Music Manager, or modified the Aether's biome data?

nu290 commented 5 months ago

when confirming this, it was in creative. no config variables were tweaked in the aether. for music manager, i have shortened the music interval to min 4 max 6. another mod i now suspect is Deep Aether that adds biomes. i'll test that

nu290 commented 5 months ago

further testing revealed that this bug occurs when i switch between creative and survival modes using F3+F4. biomes do not appear relevant. i confirmed this with vanilla1.20.1 + neoforge47.1.88 + aether1.20.1-1.0.0-neoforge + music manager1.20.1-1.3.13, and no extra mods. i could not properly test without music manager because the music is too infrequent.

this did not result in the abrupt stopping of a music piece for another to begin. that phenomenon did not occur at all during this test session

Builderdog841 commented 4 months ago

Okay, I actually found what's causing this issue. In the biome json files the "replace_current_music" field is set to true which means that it resets the music delay everytime a player switches biomes. So this issue should be fixable by simply setting it to false