The-Aether-Team / The-Aether

The original "The Aether" mod, rewritten and ported to modern Minecraft versions.
https://modrinth.com/mod/aether
GNU Lesser General Public License v3.0
347 stars 112 forks source link

Bug: Aerogel walls should not cull the faces of adjacent opaque blocks #1934

Open muzikbike opened 9 months ago

muzikbike commented 9 months ago

What Feature Types Apply to This Bug?

Block

Other Type

No response

What Type of Bug Is This?

Annoyance

Forge Version

47.2.0

The Aether Version

1.0.0-neoforge

Is This Bug a Conflict With Another Mod?

No response

Client Log

No response

Crash Report (if applicable)

No response

Steps to Reproduce

What You Expect To Happen

The faces adjacent to the wall blocks would not be culled, since aerogel walls can be seen through.

What Actually Happened

The faces are culled, which looks odd. Aerogel walls should only be able to cull the faces of other aerogel walls (but should still be culled by other walls).

Additional Details

2023-12-28_03 24 17 2023-12-28_03 24 20

Please Read and Confirm The Following

bconlon1 commented 9 months ago

Might be fixable with an override to the hidesNeighborFace method.