The-Aether-Team / The-Aether

The original "The Aether" mod, rewritten and ported to modern Minecraft versions.
https://modrinth.com/mod/aether
GNU Lesser General Public License v3.0
360 stars 118 forks source link

Bug: Sheepuff (potential Sun Spirit fight / Sheepuff Interaction) Crash #2337

Open Datgek opened 3 weeks ago

Datgek commented 3 weeks ago

What Feature Types Apply to This Bug?

Entity

Other Type

No response

What Type of Bug Is This?

Crash

Forge Version

43.4.0

The Aether Version

1.4.2-forge

Is This Bug a Conflict With Another Mod?

No response

Client Log

https://gist.github.com/Datgek/058a355c555ad2f304a869270704eab7

Crash Report (if applicable)

https://gist.github.com/Datgek/9212b0116d8d3318a7df42573a5fd666

Steps to Reproduce

(Info gathered second hand from a player on a private server, who was present in the Aether dimension at time of crash.)

Random chance. (I'm unsure if there's any real connection, I simply don't know how to read logs well enough.)

Crash happened during the Sun Spirit Boss fight, boss arena was exposed to the outside environment, crash happened after "He (Sun Spirit) had alot of fireballs spawned and I think he charged at me".

What You Expect To Happen

No crash.

What Actually Happened

Crash via server tick timeout, automatic force close after 1 tick took 600 seconds.

Additional Details

As of writing this report it hasn't been recreated (by my understanding the arena's coordinates weren't written down/weren't saved in time via modded map), The Aether mod is being used as a part of a custom modpack, Optifine is not present in this pack. Server is running off of a Ubuntu/CasaOS PC, using crafty controller.

Please Read and Confirm The Following

bconlon1 commented 3 weeks ago

How did the boss arena get exposed to the outside environment? This is meant to be impossible to avoid issues.

Datgek commented 3 weeks ago

Had to wait on the info to be passed to me, the arena didn't generate exposed, it generated "mostly buried but broke through a mountain", it seemed to be an interaction with another mod, from what the player could tell a "water spell" (aoe, either places water at targeted point or extinguishes an entity) from the Ars nouveau mod mixed with the fireballs and somehow broke the walls of the arena. My only guess is that it replaced the arena walls with water blocks. This was supposedly near/when the server froze. (Sorry for the semi-vague info, I've nothing first hand to go off of here.)

bconlon1 commented 3 weeks ago

Hmm, could the player try to reproduce this with bedrock blocks? I'd like to see if there's maybe more protections I could apply to the dungeon blocks.

What I can say about the provided log itself is it doesn't seem as though its the Sheepuff code's fault even though the Sheepuff was the entity that had the issue happen to it; it looks like movement of the entity or collision checks during its movement took too long to process for some reason. It could maybe happen while something else is causing server lag? Maybe the fireballs caused lag somehow but I'm not sure how they would here.

Datgek commented 3 weeks ago

Tried replicating it myself in a singleplayer world, couldn't get anything to break, tried both bedrock and inside the arena, but I did notice that during and after the boss fight there were semi frequent FPS spikes whenever the arena area itself was being rendered on screen. I'll see if I can't monitor the server's tps next time someone fights the boss again. 2024-11-04_19 39 36 2024-11-04_19 44 02

Datgek commented 2 weeks ago

Well, another crash, exactly the same as the first, happened during the sun spirit fight, only the 1 player fighting it was online, after the server auto recovered the player logged in mid-boss fight, on their end they had apparently killed the boss and gotten out of the arena before their client realized the server was down.

bconlon1 commented 2 weeks ago

Can you provide the new log this time? Was this fight in an enclosed dungeon?

Datgek commented 2 weeks ago

Arena was fully enclosed crash log: https://gist.github.com/Datgek/23b0f8f1c8fbba6e81ea735bebcfd0ad debug log: https://gist.github.com/Datgek/5db6062f775ba0168e4cd641d906c7f8

bconlon1 commented 2 weeks ago

Weird, I'll have to dig into what could be causing this.