Bug: Game crash while starting with mod Tips - Githubissues

The-Aether-Team / The-Aether

The original "The Aether" mod, rewritten and ported to modern Minecraft versions.

https://modrinth.com/mod/aether

GNU Lesser General Public License v3.0

360 stars 118 forks source link

Bug: Game crash while starting with mod Tips #2372

Closed NumberSir closed 1 week ago

NumberSir commented 1 week ago

What Feature Types Apply to This Bug?

Other (Please Describe)

Other Type

compatibility

What Type of Bug Is This?

Compatibility

Mod Loader

Fabric

Mod Loader Version

0.16.9

The Aether Version

1.5.1-beta.3

Is This Bug a Conflict With Another Mod?

modid: tipsmod; version: 21.1.2

Client Log

https://gist.github.com/NumberSir/a26f1ba39a04d0636d3e65715446e41b

Crash Report (if applicable)

https://gist.github.com/NumberSir/441005aea8f170232cb66dd8caa442e8

Steps to Reproduce

install

then start the game

What You Expect To Happen

game starts well

What Actually Happened

game crashed

Additional Details

No response

Please Read and Confirm The Following

[x] I have confirmed this bug can be replicated without the use of Optifine.
[X] I have confirmed this bug is on the most recently supported version of Minecraft.
[X] I have confirmed the details provided in this report are concise as possible and does not contain vague information (ie. Versions are properly recorded, answers to questions are clear).
[X] I have confirmed this bug is unique and has not been reported already.
[X] If playing on a modpack, I have reported this bug to their issue tracker already.
[X] I have confirmed that I'm reporting a bug in The Aether I, not The Aether II.

bconlon1 commented 1 week ago

My current theory is that our code for reloading the Tips compatibility resource pack according to a config here https://github.com/The-Aether-Team/The-Aether/blob/ef6706245a4feb7e75ec0feb3efc964470dabf1c/src/main/java/com/aetherteam/aether/client/AetherClient.java#L139 and here https://github.com/The-Aether-Team/The-Aether/blob/ef6706245a4feb7e75ec0feb3efc964470dabf1c/src/main/java/com/aetherteam/aether/client/AetherClient.java#L200 has to be moved to a later point in client loading or something. This also seems to happen only on Fabric which is interesting. However on both loaders it seems our Tips compatibility is also out of date which will have to be fixed.