The-Alpha-Project / alpha-core

0.5.3 experimental emulator written in Python.
GNU General Public License v3.0
260 stars 77 forks source link

TODO: Remove pet trainer duplicates #979

Closed GizzleBizzle closed 1 year ago

GizzleBizzle commented 1 year ago

Two of the pet trainers:

Bernie

I believe that Spawn 1 is in this spot because in later patches this NPC was changed to a food and drink vendor in Nethergarde. Since the Nethergarde keep hasn't been changed into its vanilla model yet, he is just standing in place that would eventually become his shop.

However both Spawn ID and Guid suggests, that Spawn 1 is the original NPC, with his spawn-point not artificially added like Spawn 2

Potential solution Remove the correct standing Spawn 2, move Spawn 1 into Spawn 2's former place. This way we can have genuine mob in the correct place.

Bolyun

Spawn 1 is there most likely due to similar situation Bernie had. This area will be eventually changed in the future and Bolyun will be moved there to serve as a general according to WoWhead. Spawn 2's general location was confirmed by @geo-tp in #789 as Darnassus, so this one should be used.

However, distinguishing which spawn is the original one here is trickier, since both spawns have high Spawn ID and Guid.

Potential solution I would suggest doing the same thing as with Bernie's spawns - remove Spawn 2 and move Spawn 1 into Spawn 2's former place, since lower IDs usually have a higher chance of being genuine.

Still, the call is Yours.

If You decide to make use of my suggestion, I would also reccomend to take care of Spawn 1's campfire, which is also buried inside inaccesible mountains.

I have archived its details in case we need to restore it, which is very unlikely, but still. Bolyan's campfire

mindphluxnet commented 1 year ago

Is Bernie supposed to hold a bottle as spider trainer too? Makes little sense if you ask me.

Fluglow commented 1 year ago

Found a few more duplicates.


> SELECT entry, name, subname FROM creature_template ct INNER JOIN spawns_creatures sc ON ct.entry = sc.spawn_entry1 WHERE ct.subname LIKE "%Trainer%" AND sc.ignored != 1 GROUP BY ct.name HAVING COUNT(*) > 1 ORDER BY ct.entry;
+-------+-------------------+----------------+
| entry | name              | subname        |
+-------+-------------------+----------------+
|  2878 | Peria Lamenur     | Cat Trainer    |
|  2941 | Lanie Reed        | Spider Trainer |
|  3546 | Bernie Heisten    | Spider Trainer |
|  3689 | Laer Stepperunner | Wolf Trainer   |
|  3698 | Bolyun            | Spider Trainer |
+-------+-------------------+----------------+
mindphluxnet commented 1 year ago

I've handled them all now.

geo-tp commented 1 year ago

Capture d’écran_2023-03-16_15-08-27

Peria Lamenur should be double spawned

mindphluxnet commented 1 year ago

Okay, I'll respawn her at the airstrip.