search

The-Apiary / buzz

A podcast client with functionality inspired by Rdio
0 stars 2 forks source link

Change id dynamic segments to something more descriptive #16

Open everett1992 opened 10 years ago

everett1992 commented 10 years ago

Episode and podcast use the records id as their identifier in Ember routes (eg podcasts/1, episodes/1234)

I'd rather use the podcast or episodes title. It makes the url pretty, and you can use url autocomplete to find episodes or podcasts you view often.

I'm not sure what the best serialization technique is. Strip illegal characters, replace spaces with underscores, limit length?

epalace510 commented 10 years ago

Thinking about char length limits, 80 is a bit long for smaller windows, 30 seems like enough to get the point. Shouldn't be too difficult to implement.

epalace510 commented 10 years ago

Alternatively, do it like reddit. [url]/[id]/[string description].

everett1992 commented 10 years ago

Do you want to work on this, it's a good change to make.

I think something like /episodes/show/:id/:title is best. The files to change should be app/assets/javascripts/router.js.coffee and app/assets/javascripts/routes/show_route.js.coffee