[WIP] Shapes & workbenches

The-Architect-Crew / the-architect-game

Minetest subgame, for stability, consistency and fun

GNU Lesser General Public License v2.1

6 stars 0 forks source link

[WIP] Shapes & workbenches #58

Closed neinwhal closed 2 years ago

neinwhal commented 2 years ago

[x] Implement shapes
[x] Implement workbench
[x] Add workstations
[x] Implement furnace
[x] Polish up everything (textures & listring)

neinwhal commented 2 years ago

Workbench is ready for review & merging. While there's still some minor polishing, I consider the essential features completed. Regarding crafting recipe, ill incorporate that after the other new materials are added, as i wanted to make use of some of them.

As stated previously, the UI for all the cooking and crafting is accessible through the workbench node. You have to add workstations to unlock more tabs to use within the workbench. And these workstations have to be fueled, for you to craft/cook items in the workbench.

I tried to add as many visual cues as i could to explain everything, so everything else should be figurable, if not, let me know, and ill try to improve on that.

neinwhal commented 2 years ago

For testers; I'm interested in these 3 things

Ease of usage > Are you able to figure how everything works?
Exploitability > Are you able to dupe items
Any bugs I didn't manage to spot in my testing

neinwhal commented 2 years ago

Additional bugs to fix;

[x] Prevent adding more microblocks when input is full
[x] Make the workbench check (for stations) actually detect for workbench without a link

EDIT: done

neinwhal commented 2 years ago

I added a 4x4 crafting grid because it felt weird that the multicraft station starts on a page that craft stairs. This crafting grid uses a button to get output, because there was no good way to do this with the inventory format, as i have learnt through the furnace. Additionally, there's now support for 4x4 crafting recipes, so if anyone of you want to make use of this for the new nodes.

neinwhal commented 2 years ago

I consider everything to be complete now. Just awaiting review and testing to ensure everything is working correctly.

This pull does the following

Add shapes API
Relics of stairs are converted to shapes
Remove mtg furnace
Add workbench with 3 workstations (Tablesaw, CNC Table, Furnace)
(Workbench) Incorporate the following into a circular_saw-like crafting format; stairs; fence; walls; panes; columnia
(Workbench) Support for a 4x4 crafting grid
Fix fencegate textures
Increase luacheck max_line_length to 400 (There were a couple of long lines in the code, which I preferably prefer to keep them long, for both readability and organization)
Adds a bunch of GUI icons for use in the core mod

neinwhal commented 2 years ago

@lisacvuk @lumberjackgames What are the thoughts on these lines used for registering the shapes? https://github.com/Craigs-Crew/edgy-dark-ominous-game/blob/shapes/mods/shapes/init.lua#L6-L80 I wanted it to be a very condensed version because i felt it would be even messier having a non-condensed version for each. Of course, this condensed version is making luacheck a very unhappy boy.

mannijac commented 2 years ago

What are the thoughts on these lines used for registering the shapes?

If you are talking about using the table of definitions instead of writing out the registration for every node, yeah, this is fine

neinwhal commented 2 years ago

Merging for now to incorporate shapes API and GUI textures. Workbench refinements will continue to be made directly in master.