Closed theraven262 closed 2 years ago
General:
allfaces
the best option for the glass nodes? I suggest experimentation with glasslike
and its relatives. allfaces
can have some weird results with certain edges not renderingMinor:
Ore drops:
Oregen:
Regarding oregen amount and quantity, that would require actual gameplay to determine, so ill slide all these concerns to push it in first, and then we can adjust accordingly. So far, from a quick overview, everything looks fine in this regard.
Everything sounds good to me, but since I consider it a major change in how oregen is managed and with the introduction of a hard boundary, I'll like to hear more opinions on it. @lisacvuk @lumberjackgames I'll leave this up till the end of this week. Once there's another approval before then or it reaches the deadline; this is clear for merging. ^ reminder if anyone is going ahead with the merge, do squash the commits and add descriptors accordingly for tidiness
EDIT: btw, the minor mtl comment refers to the fact that there's mtl data inside the obj file itself usemtl mtllib
, not with regards to the already removed mtl file, but its just a minor thing as stated, just scratches my ocd a bit :p
Zoomed over the code, seems alright, +1
Overall I like the idea of stratification. I do think -2000 might be too shallow for a long running game map and that it is more efficient in terms of map size and cleanliness to have players be able to mine down below their general area for more of a material than to have to wander to new map for more materials, especially if players start protecting blocks of underground areas over time. This may also eventually lead to more surface degradation and open mine shafts over deep mining.
Overall I like the idea of stratification. I do think -2000 might be too shallow for a long running game map and that it is more efficient in terms of map size and cleanliness to have players be able to mine down below their general area for more of a material than to have to wander to new map for more materials, especially if players start protecting blocks of underground areas over time. This may also eventually lead to more surface degradation and open mine shafts over deep mining.
I don't have anything against adding more layers so that we can expand down to -6000 or so. I thought it would get too monotonous, essentially having an alternating layer of granite and a layer of marble. But the depths can be reworked so that we add more basalt layers closer to the surface and more obsidian ones closer to the bottom. Though I would probably have to rework the layer thickness for each so that there is still some progression in that regard.
The original idea didn't leave too much space (stone) in between layers, as the layers were meant to be a source of ore and fill in everything at their depth. Essentially, the depth is more dependent on how many more world layers we would like to add in the future. I would consider the surface/sky height to be around 2000, as carpathian mountains can generate well above 512, and some people might want to build high. Leaving us with a world of 8000 height with the new idea, twice as much as originally, yet I don't see us making that many worlds that the height of 2000 would be fully utilized.
I wanted to make people mine horizontally, rather than just straight down. This is why the ores are stratified and essentially very close to the surface. I wouldn't like having to mine down 4000 blocks only to know that then I'm able to search for the ore that I need. Of course this can still happen with very rare ores such as porphyry and mithril. Yet, I don't like having no certain way of knowing if the ore which I am looking for will show up at all during my mining session.
I also see that there is an opposite argument which I could also take, ore rarity increases the need of players to trade in these ores. So, while I support the presence of trading on the server, in this case the availability of the ore that I decided to build with is no longer only dependent on noise, but rather also on someone else finding the ore and setting up a shop. Which when I think about it, and consider that the shops should be easy to set up, I find contributes to the gameplay and therefore is beneficial to the overall experience.
The issue arises if no one sets up a shop, or if all the shops are bought out. Making the only source of the ore be noise. And this is why a balance in ore generation is required, if we want the players to both trade in ores and be able to mine enough of the ore in order to build. I would say that the amount of ores required for building in most cases is related to how the specific ore is used. And with more depth available comes the need for more balance.
For example, gold is used for details, it should therefore be more rare. Marble can be used for details, but with the addition of variations, very many things can now be built with marble (one can build most of a building using marble variations). I am of course not able to figure out all the uses of a material, and thus I can't balance this out by myself. Still, I did some changes in this direction when making granite, marble, coal, basalt and iron generate much more often than in mtg/darkage. As I mentioned before, I am considering iron to be a more common building material now, because I see many uses for it. I don't see as many uses for what is essentially recolored iron, copper, bronze, tin, silver etc.
You might notice that obsidian looks rather bad in the form of any variation. Actually I find it as useful for building as it was before the variations were added. I did add two giant strata of obsidian to the bottom of the world, but this was a more thematic thing, I don't find obsidian useful, but it fits the theme of hell and the whole thing was rather easy to implement, so why not. I'm open to the idea of retexturing obsidian so that its variations become more distinct, as I kept with the original look for the current textures.
Overall as we have to agree upon some of the things such as specific ore rarity and at which depth, I think the best way of making sure that everyone's ideas are considered is to post them on this thread or make a new issue. I'll be adding/changing the oregen as per any agreements we make, and if we don't manage to agree upon anything new I'll just increase the depth to -6000 and try to populate the underground with ores as well as I can.
Do start a new issue for more in-depth discussion if required and link back here. Having this discussion here might result in a buried thread.
@theraven262, what you have laid out sounds good. -6000 should be plenty I think but we can always expand more and regenerate lower levels of map to clean up if needed.
Just to share some thoughts that popped in my mind was maybe a shallow/easier to mine section with a good mix of layers of all the most useful materials as you described and then a deeper section with wider bands of the most useful building materials to make a pseudo biome feel at different layers. Each section could have pockets of "premium" blocks, maybe with some light mining obstacles (obsidian pools?) deeper down and rare items peppered around to keep the large cavern exploring interesting.
Added new ores and ore generation. Detailed overview Main ideas behind these changes: