The-Balance-FFXIV / glam

A hugo theme for the balance
Other
5 stars 22 forks source link

Theming still needed for "general" guide pages #280

Open lailleo opened 2 years ago

lailleo commented 2 years ago

As it stands, guides published not under a job don't have any CSS assigned. Mentors have been asking for some form of theming to publish these and directly link to.

nonowazu commented 2 years ago

The answer depends on a lot of things, but to start:

xpdota commented 2 years ago

Speaking for myself, an example would be the general healer prog guide. Ideally, it should just look like any other healer guide page. As for the "route", I think that would vary by guide. e.g. mine would be from the healer role landing page.

nonowazu commented 2 years ago

@xpdota - given how hugo works, templates are rendered based on routes. Having a route as an example informs how the template generation works. You can read the docs about that here.

nonowazu commented 2 years ago

If you're just looking for something generic, just


mkdir content/jobs/melee/ninja/guides/
cat << EOF > content/jobs/melee/ninja/guides/standardized-title.md
---
title: My first guide
card_header_image: /img/jobs/nin/basic.png
authors:
  - nono
patch: "6.11"
lastmod: 2022-07-20T01:02:03.456Z
changelog:
  - date: 2022-07-20T01:02:03.456Z
    message: My first guide submission
---
I can read more about how frontmatter works in the documentation [here](https://gohugo.io/content-management/front-matter#readout)
EOF

If you need something closer to other guide pages, look at `kind:` and `layout:` frontmatter variables.
nonowazu commented 2 years ago

Actually, if that's all you need, then you can close this issue since the functionality is available in the static site today (assuming you created the folders and configure the editor for it – see docs here).

furstblumier commented 2 years ago

What is desired is the possibility to create a guide under eg https://www.thebalanceffxiv.com/jobs/healers/ For eg healer independent guides. The guide should link to idk https://www.thebalanceffxiv.com/jobs/healers/my-cool-guide And render like any other healer guide. Instead of sage in the header with the job symbol something generic healer like should be visible etc

furstblumier commented 2 years ago

Same for general guides that do not fall under a job category. Eg https://www.thebalanceffxiv.com/jobs/my-general-guide

furstblumier commented 2 years ago

Actually instead of putting it under /jobs/ it would be better to have them under https://www.thebalanceffxiv.com/general-guides/

nonowazu commented 2 years ago

Thank you for answering the questions. For role-based guides, I would suggest /jobs/${role}/guides/, just putting /jobs/${role}/foo.md results in nasty work because of how the template lookups happen:

image

There are several solutions for this (from least preferable to most preferable):

MlleCanary commented 2 years ago

Actually instead of putting it under /jobs/ it would be better to have them under https://www.thebalanceffxiv.com/general-guides/

This would allow us to differentiate similar to the way that raid guides are done, which would allow for general healing guides, general dps guides, general tank guides, prog guides for each class, and all the other general guides that have been in the planning or drafting stage to be in one place.

From an organizing and editing perspective, this makes the most sense to me and would not require any redesign of role landing pages to accomodate another guide.

If the structure were to be similar to the raid guides, where it could be organized by type (instead of Ultimate/Savage/Panda/Eden/Whatever Healer/Tank/DPS/All) would allow a lot of flexibility going forward and not look strange if some jobs had guides ready to go immediately and others did not have anything on that page from role landing.

nonowazu commented 2 years ago

I'll re-emphasize because I think it was missed from my previous post to encourage the solution to nest generic guides under a guides route (e.g., /jobs/healers/guides/, /jobs/melee/ninja/guides/, etc). This makes sense for a number of reasons: