The-Balance-FFXIV / glam

A hugo theme for the balance
Other
5 stars 24 forks source link

First pass at documenting partials #289

Closed nonowazu closed 2 years ago

nonowazu commented 2 years ago

Making inroads to solving #288, this begins adding documentation to some of the partials, which might inform later design decisions. After some looking (and frankly only documenting a 'default' card), the header and footer helpers seem a tad anemic (or too broken out).

If the reviewer wouldn't mind adding a list of partials needed for a "good" fist pass, I'll start adding those to this PR.

github-actions[bot] commented 2 years ago

1920x1080

1920x1080

1280x720

1280x720

iPhone X

iPhoneX

nonowazu commented 2 years ago

Hey, is there any traction on reviewing this? I know admins said they wanted to see more activity from me, but I can't really do much to help without some amount of feedback here.

lailleo commented 2 years ago

Hey, is there any traction on reviewing this? I know admins said they wanted to see more activity from me, but I can't really do much to help without some amount of feedback here.

A lot of the devs still active at the moment were progging the tier the last few weeks, I'll poke again to try to get eyes on it. Sorry for the delay.