Closed nonowazu closed 1 year ago
Code looks good, could you put the instructions for running the script somewhere that people will be able to find them? (Also maybe a package script if possible?)
I put the instructions in scripts/README.md
which should be pretty immediately available when browsing github on the web, or just opening and reading.
I'd really rather not make this a package script due to the nature of python virtualenvs – unless you want to make it clear that the package script won't work unless you've set up the basics yourself (then I can add it in another PR)
Add some python and a small library I created to dynamically generate the netlify configuration. Successful dogfooding of this in dev should result in me pushing that library to pypi for future consumption (removing the git dependency in requirements.txt).
Current instructions for use (from the scripts directory):
python -mvenv env
(I think this works with python 3.10 or higher, but when I'm done it should be 3.7 or higher)pip install -r requirements.txt
python generate_config.py > ../exampleSite/static/admin/dev.yml
yarn start:dev
commandsI wouldn't bother too hard with reviewing dev.yml, but I figured it would be nice to include it as part of this PR for "rapid start" (I don't see this changing too often)