The-Balance-FFXIV / glam

A hugo theme for the balance
Other
5 stars 24 forks source link

Generate config dynamically #308

Closed nonowazu closed 1 year ago

nonowazu commented 2 years ago

Add some python and a small library I created to dynamically generate the netlify configuration. Successful dogfooding of this in dev should result in me pushing that library to pypi for future consumption (removing the git dependency in requirements.txt).

Current instructions for use (from the scripts directory):

I wouldn't bother too hard with reviewing dev.yml, but I figured it would be nice to include it as part of this PR for "rapid start" (I don't see this changing too often)

hintxiv commented 1 year ago

Code looks good, could you put the instructions for running the script somewhere that people will be able to find them? (Also maybe a package script if possible?)

nonowazu commented 1 year ago

I put the instructions in scripts/README.md which should be pretty immediately available when browsing github on the web, or just opening and reading.

I'd really rather not make this a package script due to the nature of python virtualenvs – unless you want to make it clear that the package script won't work unless you've set up the basics yourself (then I can add it in another PR)