The-Balance-FFXIV / glam

A hugo theme for the balance
Other
5 stars 24 forks source link

Add missing font-weights for Roboto #314

Closed teatwig closed 1 year ago

teatwig commented 1 year ago

The font weight 300 was missing, which made "font-light" fallback to the font weight 100. This provides bad readability at a font size of 14px. Roboto does not provide the font weight 600 for "font-semibold", but for consistency I added the font weight 500 as well. I also updated the admin index.html so the fonts used in the admin UI match those in the theme. It might make sense to update it in the main repository as well.

This has been especially visible on the copyright text on the footer.

Before: image

After: image

teatwig commented 1 year ago

It probably make sense to create a partial with tags inside head that are shared between the theme and admin UI. Although the question is if the admin UI even needs these changes. I haven't looked that deeply into the features of Netlify CMS.