Add support for optional job intermediate guide page

The-Balance-FFXIV / glam

A hugo theme for the balance

Other

5 stars 24 forks source link

Add support for optional job intermediate guide page #355

Closed Vantablak closed 5 months ago

Vantablak commented 5 months ago

Add optional Intermediate Guides section to list.html (/job page)
Modify generate files to add intermediate guide section to the CMS
Did not push changes to dev.yml/config.yml, as it seemed to include info about pct/vpr as well that wasn't already added, so unsure whether it needs to be committed
Current layout of the job index page needs feedback, not sure if intermediate guides warrants a whole section.
Might wanna change the icon for intermediate guides (currently using the same graduate cap as advanced guides)

Vantablak commented 5 months ago

@Vantablak - can you use the editor in dev mode to add some example content so it's easily visible. It makes it easier to test that you've gone end to end with the editor changes.

@nonowazu So just pushing the changes to dev.yml and exampleSite/job/blah/intermediate-guide.md is cool? Also, like I mentioned in the PR description running econfgen on dev.yml will also push in some pct/vpr additions, is it fine to leave those in?

nonowazu commented 5 months ago

Yes, the entire reason the exampleSite directory exists is to:

test the editor
have content that doesn't affect the theme while showing that it works without requiring the balance-static repo.

Also you don't have to, but it might be nice to run rye run ruff format src since I see I missed a newline.