The-Cat-Town-Craft / Carpet-TCTC-Addition

A fabric-carpet extension mod. It offers some interesting features.
https://www.curseforge.com/minecraft/mc-mods/carpet-tctc-addition
GNU Lesser General Public License v3.0
30 stars 4 forks source link

[Bug] Not compatible with Carpet Fixes #7

Closed Hendrix-Shen closed 1 year ago

Hendrix-Shen commented 2 years ago

Minecraft Version

1.19

Carpet TCTC Addition Version

2.0.161+79d49e9

Description

Redirects a target in conjunction with Carpet Fixes, causing a crash on Mixin. This issue requires a solution other than disabling Mixin using MixinPlugin. We are working on it.

Related issues: https://github.com/The-Cat-Town-Craft/Carpet-TCTC-Addition/issues/5 https://github.com/The-Cat-Town-Craft/Carpet-TCTC-Addition/issues/6 https://github.com/fxmorin/carpet-fixes/issues/87

To Reproduce

Install both Carpet TCTC Addition and Carpet Fixes.

Expected behavior

No response

Log

No response

Latest CI build tested

Aculoss commented 2 years ago

Problem has not been fixed but now conflicts with autocrafting table extension, the build by Crec0 i believe.. crash report under.

[14:50:31] [main/INFO]: Loading Minecraft 1.19 with Fabric Loader 0.14.8 [14:50:31] [main/INFO]: Loading 145 mods:

Hendrix-Shen commented 2 years ago

I have tried to fix this in a90c572, but without much testing and this may only be a temporary solution.

Aculoss commented 2 years ago

Still not fixed, unfortunately

Hendrix-Shen commented 2 years ago

Still not fixed, unfortunately

Can you upload the latest logs?

Hendrix-Shen commented 2 years ago

Used a more hacked way, but still improving and now it works.

FxMorin commented 2 years ago

Has this fixed the issue?

Aculoss commented 2 years ago

It has indeed, apologies for the late reply, had both my kids birthdays and a bit rushed off my feet. No conflicts anymore, thank you for the collaborative fix

On Wed, 20 Jul 2022, 3:49 pm Fx Morin, @.***> wrote:

Has this fixed the issue?

— Reply to this email directly, view it on GitHub https://github.com/The-Cat-Town-Craft/Carpet-TCTC-Addition/issues/7#issuecomment-1190383356, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEUHPZ742EKQZWJ5FL3NKM3VVAGVZANCNFSM52HZ6ATQ . You are receiving this because you commented.Message ID: @.***>

FxMorin commented 2 years ago

Alright thanks