search

The-Cataclysm-Preservation-Project / TrinityCore

Archived repository for WoW 4.3.4.15595. The project will be reworked for Cataclysm Classic as an official new branch of TrinityCore at https://github.com/TrinityCore/TrinityCore
GNU General Public License v2.0
237 stars 97 forks source link

Core/Movement: Hover float's not taken into account when fighting and chasing creatures #300

Closed Nyr97 closed 2 years ago

Nyr97 commented 2 years ago

Description: Creatures that use hover float on the ground normally take their hover float into account for cosmetic purposes when fighting and chasing creatures. I was told, maybe, it had to do with the fact that the creature_model_info was missing its data, but it's not the case for, e.g. 33997:

image

Current behaviour: Creatures using creature_movement hover (2) on Ground do not take their hover float into account when fighting or chasing creatures.

image

Expected behaviour: Hover float should be taken into account when fighting or chasing creatures.

Steps to reproduce the problem:

  1. Add HoverHeight 2.8 on creature_template where entry Arthura (45473).
  2. Add Ground 2 on creature_movement_template where entry Arthura (45473).
  3. Cast Summon Arthura (84941) and make the summoned creature fight anyone.
  4. Watch it clips on top of it.

TC rev. hash/commit: TrinityCore rev. d1ab352df228+ 2021-10-20 07:30:57 +0200 (silverpinereworks branch) (Win64, RelWithDebInfo, Static) (worldserver-daemon)

TDB version: TDB 434.21071

Operating system: Windows 10 (x64)

Ovahlord commented 2 years ago

That's not an issue. she has a combatreach of 0.6 which is tiny. Shen a unit is hovering, the range is calculated spherically so units that are under her will get even closer.

Nyr97 commented 2 years ago

Apparently, the bug was not related to the hovering unit, but the other units as they lack any information under their display info. I updated them on the SQL and the GetChaseRange now works as it should.