Fix Warrior Enraged Regeneration spell

[AGandrup]

Changes proposed:

• Warriors will no longer be able to gain Enrage effects while Enraged Regeneration is active, as stated in the Enraged Regeneration tooltip.
• Enraged Regeneration will no longer be able to be activated from Vengeance, as stated in the Vengeance tooltip.

Tests performed:

• Tested in game, works as intended.

Known issues and TODO list:

• TODO/Suggestion: Perhaps it would make sense to add more unit states in relation to spell mechanics, for example UNIT_STATE_ENRAGED, so that in a case like this we could use the CONDITION_UNIT_STATE to check if unit is enraged, instead of having to go through all possible spells with enrage effects etc.

[Ovahlord]

You will be surprised but there already is AURA_STATE_ENRAGE which is the requirement for enrage based spells to be casted. So checking for the aura state is the way to go here. Also usually stuff like this belongs into spell scripts

[AGandrup]

Oh okay, excellent. I will have to look into this some more then. Is AURA_STATE_ENRAGE something that can be used for conditions as well or is that only related to spell scripts?

[Ovahlord]

I's only available for spell scripts and that's fine because stuff like this usually belongs into spell scripts at least for class scripts

[AGandrup]

Right, that makes sense. Was just wondering

[Ovahlord]

So from what I read on the webs, Enraged Regeneration does not block the cast of these effects, instead it just renders you immune to any other spell that uses MECHANIC_ENRAGE. So that one is easy to fix

[AGandrup]

So what that means is, if Enraged Regeneration is active then Berserker Rage and Deathwish can still be used but wont do anything? So you would basically just waste your cooldown and rage on nothing? Seems odd if thats the case...

Edit: There is this following patch note from WotLK: Patch 3.1.0 (14-Apr-2009): While this is active, the warrior is blocked from using abilities that trigger being enraged (which would do nothing and waste the cooldowns). Source: https://wowwiki-archive.fandom.com/wiki/Patch_3.1.0

So I guess it should waste the cooldown. The phrasing is kinda bad/confusing to me because it also states that the warrior is "blocked from using abilities that trigger being enraged", so ye idk.

[Ovahlord]

Looks like it. The only difference between the WotLK and Cata version is that the Cataclysm version no longer consumes enrage effects but otherwise, their functionality is identical and based on that, the WotLK also applied the enrage immunity which, weirdly enough, is no longer in the Cataclysm dbc entry for it.

[Ovahlord]

f94ce7954377e4486dae2c2603c0898dc12b2a49 there we go

[AGandrup]

f94ce79 there we go

Alright, going with that solution then. Awesome 👍