search

The-Cataclysm-Preservation-Project / TrinityCore

Archived repository for WoW 4.3.4.15595. The project will be reworked for Cataclysm Classic as an official new branch of TrinityCore at https://github.com/TrinityCore/TrinityCore
GNU General Public License v2.0
239 stars 97 forks source link

GameObjectModel created twice for transport #362

Closed Lordron closed 2 years ago

Lordron commented 2 years ago

Description:

CreateModel is called twice for MapTransport. First call in Transport::CreateTransport https://github.com/The-Cataclysm-Preservation-Project/TrinityCore/blob/master/src/server/game/Entities/Transport/Transport.cpp#L308

second one https://github.com/The-Cataclysm-Preservation-Project/TrinityCore/blob/master/src/server/game/Entities/Transport/Transport.cpp#L546

Expected behaviour:

second call can be safely removed

Ovahlord commented 2 years ago

that's going to be solved once I merge my transport branch