Fix Rogue spell Redirect

The-Cataclysm-Preservation-Project / TrinityCore

Archived repository for WoW 4.3.4.15595. The project will be reworked for Cataclysm Classic as an official new branch of TrinityCore at https://github.com/TrinityCore/TrinityCore

GNU General Public License v2.0

237 stars 97 forks source link

Fix Rogue spell Redirect #377

Closed AGandrup closed 1 year ago

AGandrup commented 1 year ago

Changes proposed:

Can no longer be used without any existing combo points.
Can no longer be used on target with combo points already.
Will now properly transfer combo points to a new target.
Bandit's Guile + Insights will now be transfered along with combo points as intended.

Issues addressed:

Fixes #207

Tests performed:

Builds.
Works as intended ingame.

Known issues and TODO list:

~TODO: Fix transfering bandits guile. This requires some rework of AuraScript spell_rog_bandits_guile as this will currently always clear insight buffs when hitting a new target.~

Ovahlord commented 1 year ago

I'm not a fan of this script. SetAmount is usually never being used so this implies that what you are doing here is very likely a hack. The Bandit's guile part can be solved differently by accessing the aurascript of the rogue and using a public method to change the proc guid.

AGandrup commented 1 year ago

Right, I get what you are saying - that would probably be cleaner too. I'll figure it out.

AGandrup commented 1 year ago

Actually, I'm a bit confused. Can I just move an aura from one unit to another by swapping a GUID? I don't need to specifically say "add new aura to new target", "remove old aura from previous target"?

Ovahlord commented 1 year ago

No, but you can access the player's proc aurascript and alter the previous target guid to the new one that you redirect to so the proc just keeps going as nothing has changed.