Fixed build for newer OpenSSL and MariaDB

danielsreichenbach commented 1 year ago

Changes proposed:

add support for building against OpenSSL 3.0
replaced mentions of authserver with bnetserver
updated list of external dependencies with correct information
fixed a warning in connection patcher for Linux

Issues addressed: None

Tests performed: (Does it build, tested in-game, etc)

[X] Builds
[X] Can connect and play

Known issues and TODO list: None

FuzzyWuggzy commented 1 year ago

EDIT: Turns out it's an issue with my setup, forced it to use the OpenSSL 1.1.1 compatibility packages and it still failed, I've opened up an issue here.

Thank you for this, it helped with the OpenSSL incompatibility, but it still won't build and returns this error:

[ 83%] Building CXX object src/server/game/CMakeFiles/game.dir/Maps/MapReference.cpp.o
In file included from /mnt/[UUID]/TrinityCore/src/server/game/Handlers/TicketHandler.cpp:29:
/mnt/[UUID]/TrinityCore/src/server/game/Server/Packets/TicketPackets.h:71:43: error: declaration of ‘TaggedPosition<Position::XYZ> WorldPackets::Ticket::SupportTicketHeader::Position’ changes meaning of ‘Position’ [-fpermissive]
   71 |             TaggedPosition<Position::XYZ> Position;
      |                                           ^~~~~~~~
In file included from /mnt/[UUID]/TrinityCore/src/server/game/Entities/Object/MovementInfo.h:22,
                 from /mnt/[UUID]/TrinityCore/src/server/game/Entities/Object/Object.h:27,
                 from /mnt/[UUID]/TrinityCore/src/server/game/Entities/Unit/Unit.h:21,
                 from /mnt/[UUID]/TrinityCore/src/server/game/Entities/Creature/Creature.h:21,
                 from /mnt/[UUID]/TrinityCore/src/server/game/PrecompiledHeaders/gamePCH.h:20,
                 from /mnt/[UUID]/TrinityCore/build/src/server/game/CMakeFiles/game.dir/cmake_pch.hxx:5,
                 from <command-line>:
/mnt/[UUID]/TrinityCore/src/server/game/Entities/Object/Position.h:27:20: note: ‘Position’ declared here as ‘struct Position’
   27 | struct TC_GAME_API Position
      |                    ^~~~~~~~
make[2]: *** [src/server/game/CMakeFiles/game.dir/build.make:2477: src/server/game/CMakeFiles/game.dir/Handlers/TicketHandler.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1241: src/server/game/CMakeFiles/game.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

I'm not sure this is related to your PR, I can't build the master branch without downgrading OpenSSL system-wide. It built successfully for you and no commits have been made in two weeks so I can't say what the issue is.

Thank you again

Kind regards