Open AshwinS27 opened 4 years ago
Finished coding all methods for the command DriveXFeet. We still need to determine MotionMagic/PID constants.
Please look her for advise on setting PID values for Motion Magic. https://phoenix-documentation.readthedocs.io/en/latest/ch16_ClosedLoop.html#motion-magic-position-velocity-current-closed-loop-closed-loop
Cross the Road Electonics has some great examples for this and for normal PID control loop also.
I think Motion Magic could also be used for "Turn N degrees" and "Turn N degrees absolute" too.
On Sat, Jan 18, 2020 at 3:46 PM madehong22 notifications@github.com wrote:
Finished coding all methods for the command DriveXFeet. We still need to determine MotionMagic/PID constants.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/The-Charge/Recharge2020/issues/15?email_source=notifications&email_token=ABQRZAYSGCJXCLO7K5CREZ3Q6NTEBA5CNFSM4KITVV22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKBTTI#issuecomment-575936973, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQRZA3RZ5NLPMJRWA2PTYTQ6NTEBANCNFSM4KITVV2Q .
https://github.com/CrossTheRoadElec/Phoenix-Examples-Languages/blob/master/Java/MotionMagic_TalonFX_AuxStraightPigeon/src/main/java/frc/robot/Constants.java#L33 CTRE just updated and added an example for MotionMagic for TalonFX. The link provides some constant, which could be a start for tuning on the actual Robot.
We want this command and the related method in DriveTrain because it would be crucial for AUTON. Look at PowerUp2018 and SteamBot2017 for reference.