The-CodingSloth / haha-funny-leetcode-extension

MIT License
424 stars 84 forks source link

Webscraper improvements #87

Open ArjixWasTaken opened 1 year ago

ArjixWasTaken commented 1 year ago

Please I beg of you to learn proper scraping before you decide to use an entire fucking browser (via puppeteer/selenium) for a super simple task.

What you did is the equivalent of bringing a rocket launcher to a knife fight

Here is a simpler solution:

image

image

(instead of evaling you would want to replace !0 with true and such, and use JSON.parse)

ArjixWasTaken commented 1 year ago

(the video's description did tell me to come and roast you, so I did)

ArjixWasTaken commented 1 year ago

If you want, I can teach you how to become a master web scraper.

troygidney commented 1 year ago

You should submit a pull request so we can see what you'd change. But I like the points and ideas!