search

The-Enthusiast-404 / git-begin

Git Begin is a Web App to find latest good first issues and start contributing to open source
https://gitbegin.theenthusiast.dev
MIT License
28 stars 15 forks source link

feat: multiple language selection #40

Closed sahitya-chandra closed 3 weeks ago

sahitya-chandra commented 3 weeks ago

closes #35

netlify[bot] commented 3 weeks ago

Deploy request for gitbegin pending review.

Visit the deploys page to approve it

Name Link
Latest commit c8a2305a34a1356cbc9064a66fa84c5c0f5b2562
dotslashbit commented 3 weeks ago

@sahitya-chandra Just from a quick look, I realised that it'll be a complicated task, see currently you are only changing the UI, you didn't change the logic or any state, also we need to change the API requests too.

I think it'll be best if you leave this issue and I'll give you something else to work on. If you want to try then go ahead, but I think it'll be too much over whelming for you.

Let me know what you think and then we will move forward

sahitya-chandra commented 3 weeks ago

i want to give it a try...

dotslashbit commented 3 weeks ago

@sahitya-chandra Ok then, lets go step by step

  1. Lets first update the UI to show that the multi select is happening, it doesn't need to update the state, only needs to show in the web app that multiple languages have been selected.

I hope you understand this.

One more thing, always send the updated web app screen recording.