search

The-Enthusiast-404 / git-begin

Git Begin is a Web App to find latest good first issues and start contributing to open source
https://gitbegin.theenthusiast.dev
MIT License
28 stars 15 forks source link

Fix graphql #51

Closed Sechorda closed 2 weeks ago

Sechorda commented 3 weeks ago

Resolves #49

Modified Graphql query and logic to only return:

Issues with HasPRs: False Issues with HasPRs: True if State is Open, Draft, closed, or NULL.

Some cases showed HasPR: True but state: Null. Manually reviewed and did not see any PRs for the mentioned issue, this could be a github API bug.

netlify[bot] commented 3 weeks ago

Deploy Preview for gitbegin ready!

Name Link
Latest commit dd544e50bce08897718152ef992cc492775f3c1b
Latest deploy log https://app.netlify.com/sites/gitbegin/deploys/66ce31e2c951de0008c555c3
Deploy Preview https://deploy-preview-51--gitbegin.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 55
Accessibility: 81
Best Practices: 92
SEO: 82
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sechorda commented 3 weeks ago

Tested on my end, Ready for review.

dotslashbit commented 3 weeks ago

@Sechorda I have shared a docs link in the issue, please take a look and let me know what you think?

Sechorda commented 2 weeks ago

Converting to draft to determine best strategy for filtering.

dotslashbit commented 2 weeks ago

@Sechorda Merging this Pr as it seems fine to me, Later when we'll add tests, then we can again see if it actually holds all possible cases or not.