Closed rodriveiga01 closed 2 months ago
Name | Link |
---|---|
Latest commit | d7c1eb805bc410f21002c7d82717eb9dc776230e |
Latest deploy log | https://app.netlify.com/sites/gitbegin/deploys/66d733a8e45daa0008a50452 |
Deploy Preview | https://deploy-preview-74--gitbegin.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All translations were done in the website:https://translate.i18next.com
If needed to implement other languages, I can implement before merging
@rodriveiga01 Thank you so much for your contribution. It might take some time to review it as I don't have much time for the next 2 days. I hope you'll understand
Of course, take your time. Then let me know that you think
We need to cross-check different language content too. We can't rely on a single tool. @rodriveiga01 @dotslashbit
@omjogani Can you suggest some other ways to cross check?
@omjogani I agree on cross checking but do you mean like testing various translators or other thing?
@omjogani I agree on cross checking but do you mean like testing various translators or other thing?
Either we get tested by local people, who know that language very well OR another option could be Comparing translation with different tools.
I use camelCase in variables and functions and PascalCase on class and other important things
@dotslashbit I think it can go for production now
I use camelCase in variables and functions and PascalCase on class and other important things
That's convention, I mean to say meaningful naming.
@dotslashbit I think it can go for production now
We are good to merge @dotslashbit :green_circle:
@rodriveiga01 Thank you so much for your contribution, it really means a lot and @omjogani I really appreciate your efforts into reviewing all these PRs, your experience is really helping this project.
Thank you both of you for being a part of this project. I can't be more lucky than this π
I just want to help and this seems a great project to begin to contribute in open source. Let's continue to improve
Summary
This pull request addresses issue #72 by implementing multi-language support across the website.
Changes
locale
folder containing JSON files for each supported language.locale/languageUtility.ts
.data/categories.ts
into a function to facilitate translation. All necessary logic has been implemented.mobile devices
, ensuring adequate space for the language dropdown.All changes have been tested. The page reloads to update the text strings to the new language
Contribution
This pull request resolves #72.