The-Enthusiast-404 / git-begin

Git Begin is a Web App to find latest good first issues and start contributing to open source
https://gitbegin.theenthusiast.dev
MIT License
31 stars 18 forks source link

Feature: Multi Language Support #74

Closed rodriveiga01 closed 2 months ago

rodriveiga01 commented 2 months ago

Summary

This pull request addresses issue #72 by implementing multi-language support across the website.

Changes

All changes have been tested. The page reloads to update the text strings to the new language

Contribution

This pull request resolves #72.

netlify[bot] commented 2 months ago

Deploy Preview for gitbegin ready!

Name Link
Latest commit d7c1eb805bc410f21002c7d82717eb9dc776230e
Latest deploy log https://app.netlify.com/sites/gitbegin/deploys/66d733a8e45daa0008a50452
Deploy Preview https://deploy-preview-74--gitbegin.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rodriveiga01 commented 2 months ago

All translations were done in the website:https://translate.i18next.com

rodriveiga01 commented 2 months ago

If needed to implement other languages, I can implement before merging

dotslashbit commented 2 months ago

@rodriveiga01 Thank you so much for your contribution. It might take some time to review it as I don't have much time for the next 2 days. I hope you'll understand

rodriveiga01 commented 2 months ago

Of course, take your time. Then let me know that you think

omjogani commented 2 months ago

We need to cross-check different language content too. We can't rely on a single tool. @rodriveiga01 @dotslashbit

dotslashbit commented 2 months ago

@omjogani Can you suggest some other ways to cross check?

rodriveiga01 commented 2 months ago

@omjogani I agree on cross checking but do you mean like testing various translators or other thing?

omjogani commented 2 months ago

@omjogani I agree on cross checking but do you mean like testing various translators or other thing?

Either we get tested by local people, who know that language very well OR another option could be Comparing translation with different tools.

rodriveiga01 commented 2 months ago

I use camelCase in variables and functions and PascalCase on class and other important things

rodriveiga01 commented 2 months ago

@dotslashbit I think it can go for production now

omjogani commented 2 months ago

I use camelCase in variables and functions and PascalCase on class and other important things

That's convention, I mean to say meaningful naming.

omjogani commented 2 months ago

@dotslashbit I think it can go for production now

We are good to merge @dotslashbit :green_circle:

dotslashbit commented 2 months ago

@rodriveiga01 Thank you so much for your contribution, it really means a lot and @omjogani I really appreciate your efforts into reviewing all these PRs, your experience is really helping this project.

Thank you both of you for being a part of this project. I can't be more lucky than this 😊

rodriveiga01 commented 2 months ago

I just want to help and this seems a great project to begin to contribute in open source. Let's continue to improve