search

The-Enthusiast-404 / git-begin

Git Begin is a Web App to find latest good first issues and start contributing to open source
https://gitbegin.theenthusiast.dev
MIT License
28 stars 15 forks source link

Modify filter to work on selection change without button click (Fix #55) #78

Open ST-KO opened 2 weeks ago

ST-KO commented 2 weeks ago

Summary

This pull request address issue #55, modifies the filter functionality to trigger automatically on change.

Changes

Related Issues

Screen Recording

https://github.com/user-attachments/assets/98b630c0-e675-46af-94c8-6dbaf9445e5a

netlify[bot] commented 2 weeks ago

Deploy request for gitbegin pending review.

Visit the deploys page to approve it

Name Link
Latest commit ccbdee8a96173557608854f0f0d6b802d3273215
dotslashbit commented 1 week ago

@ST-KO if you want any help please reach out to @omjogani I'm sure his experience can help you learn and implement these things.

If you are hesitant to write tests, then you can leave it but if you want to learn and implement test, then @omjogani is there to help you.

Remember there's no rush, take your time ☺️

ST-KO commented 1 week ago

@dotslashbit @omjogani That makes more sense. Thank you so much for explaining my mistake guys. I knew it shouldn't be that simple :sweat_smile: .

As for custom hook, I might take some time as I have never written custom hook before and have to learn it first. At the mean time, if you want to assign this to another contributor, I am totally ok with that. But I will still be working on it.

I'll also reach out to @omjogani for help if I am stuck. Thanks guys :relaxed:

dotslashbit commented 1 week ago

@ST-KO no no there's no rush, please take your time, learn and implement. We are here to help 😁

omjogani commented 1 week ago

@dotslashbit @omjogani That makes more sense. Thank you so much for explaining my mistake guys. I knew it shouldn't be that simple 😅 .

As for custom hook, I might take some time as I have never written custom hook before and have to learn it first. At the mean time, if you want to assign this to another contributor, I am totally ok with that. But I will still be working on it.

I'll also reach out to @omjogani for help if I am stuck. Thanks guys ☺️

Open Source is all about learning and applying, We want you to implement it and comment here if you face any difficulties, more than happy to help!