The-Fireplace-Minecraft-Mods / Block-Replacer

Replace any block in the worldgen with any other block.
MIT License
1 stars 1 forks source link

"Multiplychance" divides by height instead of multiplying by it #27

Closed zuel122 closed 3 years ago

zuel122 commented 3 years ago

Currently running minecraft 1.12.2 version, the setting that "Multiplies the block removal chance by the block's y-value" instead divides by the y-value.

Steps to reproduce the behavior: (there are probably easier ways, but this is how I figured out what the behavior was)

  1. in the config file while the game is closed, set multiplychance to true and set replacepercent to 40 (which you cannot do through opening the config from Mod List, and it won't update if the game is open and you edit the config file) and have it replace gravel with sand in the ocean and deep_ocean biomes (I replaced gravel with sand from only y=30 to y=53 but I doubt this is necessary to replicate it)
  2. then go to deep ocean and ocean and notice how everything below y=40 is sand (because 40 divided by any number less than it is over 100%) while gravel will have an increasing gradient upward.
  3. setting replacepercent to values 1 or less can also be seen to result in almost never any of the ocean gravel being converted to sand, since it'd have a likelihood around 1/32 at the lowest deep ocean points and 1/53 at the highest gravel points if it's set to 1 for 100%

    • Minecraft: 1.12.2
    • Mod Version: 2.2.0
    • Forge: 14.23.5.2854

sorry if this reads like garbage, I've never done one of these before