The-Fireplace-Minecraft-Mods / In-Game-Account-Switcher

This mod allows you to change your logged in account in-game, without restarting Minecraft.
https://modrinth.com/mod/in-game-account-switcher
GNU Lesser General Public License v3.0
78 stars 31 forks source link

IAS v9: Fully rewrite (for security, modern code, portability) #135

Closed VidTu closed 4 months ago

VidTu commented 7 months ago

What's new:

Required: (before merging)

To consider:

Resolves #84. Resolves #92. (By adding descriptive error messages) Resolves #98. (10 ports will be used, they're added manually in the Microsoft Entra, so I'm lazy to do more; Alternate authentication method was also added) Resolves #104. (By also copying the link into the clipboard) Resolves #106. (By adding descriptive error messages) Resolves #113. (By adding descriptive error messages) Resolves #115. (By adding descriptive error messages) Resolves #124. (By using new skin renderer) Resolves #130. (By rewriting UI)

Will close #120. (Deprecated) Will close #128. (Deprecated)

ghost commented 7 months ago

virus steal account

VidTu commented 7 months ago

@The-Fireplace, it should be ready for the first release candidate. Can you give me the access to the CI (GH actions) and security (security policy, etc) settings?

The-Fireplace commented 7 months ago

@VidTu Done. I went ahead and enabled Dependabot security scanning while I was at it, feel free to adjust as needed.

VidTu commented 7 months ago

Thank you. I think I'll do some more testing and will release first release candidate on Modrinth, CurseForge after the weekend. Maybe I'll also set up something like mc-publish as it's recommended by Fabric in the future to automate publishing. (especially during the release candidate phase so it won't screw everything up if it won't release on one platform due to wrong config or something like that)

VidTu commented 5 months ago

@The-Fireplace feel free to review and merge (squashing preferred). After that I'll probably push first "9.0.0-alpha.1" version to Modrinth/CF. (Unless you'll have complaints)

VidTu commented 5 months ago

oops, duel-booting into linux broke system clock and windows didn't sync time for some reason. these 3 commits were added just now, not 3 hours ago.