The-Fireplace-Minecraft-Mods / Overlord

A Minecraft mod that allows raising and commanding an army of skeletons
https://www.curseforge.com/minecraft/mc-mods/overlord
Mozilla Public License 2.0
17 stars 11 forks source link

Armor "bug" with the lithium mod #222

Closed Doomion closed 1 year ago

Doomion commented 2 years ago

While using overlord with the lithium mod the armor values on the skeletons are reduced for example, if you give a full diamond armor to a skeleton, he will only have 3 armor value, meanwhile, without lithium it's 20, which is normal.

Just take a random set of armor and equip it on a skeleton and use some kind of health indicator or something of the sort and you will notice they will have a lower armor value then normal.

(Information at the top left corner) https://drive.google.com/file/d/1ec_RT4mtOQ7Ukip075n_Ung_PHh5iyYl/view?usp=sharing--------------> Without lithium

https://drive.google.com/file/d/1Z0MRVLxbK8U1gTTmj20D4DQT9wTNPaGH/view?usp=sharing---------> With lithium

The-Fireplace commented 2 years ago

What version of Lithium did you test this with?

Doomion commented 2 years ago

version of lithium used: lithium-fabric-mc1.18.1-0.7.8.jar

The-Fireplace commented 2 years ago

Thanks! It may be a bit before I can get to it, but there is something you can do in the meantime that should fix it for you and speed up a fix. https://github.com/CaffeineMC/lithium-fabric/wiki/Configuration-File In the Lithium config, you can try overriding various options as false one by one until it starts working correctly again. Once you find which it is, let me know and I can get Overlord to make that one false by default.

I would try mixin.entity.data_tracker.use_arrays first. If that doesn't do it, you can start by disabling a whole category at a time (mixin.entity, mixin.math, etc) to find the category then check specific settings in that category.

Doomion commented 2 years ago

Im kind of new to this stuff, but I will try to fix it, if im able to fix it I will post a new comment, thanks for the reply and the suggestion.

Doomion commented 2 years ago

After a while I found out the problem is in "mixin.entity", when turned to false the values work as intended, but when I tried to find the specific subcategory causing this problem the values would always remain incorrect. I tried to change 1 by 1 the values of each variable, but it just doesn't work and I have no idea why, for now the only solution I can come up with is turning "mixin.entity" in the lithium config to "mixin.entity=false"

The-Fireplace commented 2 years ago

Hmm. I wonder if it's some combination of the entity settings then, or something that can't currently be overridden individually

The-Fireplace commented 2 years ago

Okay, looking at Lithium, there may be a few more optimizations that aren't documented. Try mixin.entity.skip_equipment_change_check=false

Doomion commented 2 years ago

yah, that solved the problem, thanks!

The-Fireplace commented 2 years ago

I'm going to leave this open until I fix it from Overlord's side