search

The-Fireplace-Minecraft-Mods / TickDynamic

Public Issues repository for the Minecraft mod Tick Dynamic.
MIT License
15 stars 3 forks source link

Concurrent Modification error #22

Closed Dalethium closed 5 years ago

Dalethium commented 6 years ago

Heya, you have concurrent modification in your mod.

stack trace

TickDynamic Version: TickDynamic-1.12.2-1.0.0.jar
Minecraft Version: 1.12.2 Forge Version: 1.12.2-14.23.2.2654

More details:

Let me know if you need anything else!

Dalethium commented 6 years ago

Upon further inspection of the code and my server, I've found a few things out:

Since I have the code downloaded, if I have the proper time and I find a fix I will create a pull request - but I don't know if I will have time.

Good luck with the bug hunt!

Let me know if you need anything else.

The-Fireplace commented 6 years ago

Thanks for all the details! I'll get on it when I have time, but I can't guarantee it'll be anytime soon. If you want to see about fixing it, I'd be glad to accept a Pull Request fixing it.

On Mon, Apr 9, 2018, 10:55 PM Daleth Darko notifications@github.com wrote:

Upon further inspection of the code and my server, I've found a few things out:

  • The Dimension with the ID of 20 causes the error by being loaded
  • Multiple Dimensions (including dim 20) are loaded upon startup, then unloaded for resource conservation reasons
  • Upon Reloading dim 20 after unloading it, the issue occurs
  • I have only skimmed over the code but a possibility is that unloading the world is not resetting the currentAge and/or list.age

Since I have the code downloaded, if I have the proper time and I find a fix I will create a pull request - but I don't know if I will have time.

Good luck with the bug hunt!

Let me know if you need anything else.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/The-Fireplace-Minecraft-Mods/TickDynamic/issues/22#issuecomment-379966097, or mute the thread https://github.com/notifications/unsubscribe-auth/AFo-rL6JTbqXwl8XhafpYYTBAWmZUpSMks5tnC0ngaJpZM4TLnaX .

Dalethium commented 6 years ago

Hey! So I have not had time to look into a fix yet, however I did notice that the dimension in question belongs to the betweenlands mod. I am not sure if this would change anything however it's probably worth noting.

The-Fireplace commented 6 years ago

Would you provide the full crash report?

Dalethium commented 6 years ago

Hey! Sorry! I got busy and it took me a while to dig it up, Here it is!

Good luck!

evhub commented 6 years ago

Getting the same error: https://gist.github.com/evhub/3f9193d6bbb85245bd22590e9a0ff335

CJenkins93 commented 6 years ago

Just got the same thing, excelsior dude, great mod Edit: Crash will absolutely happen at least once a day. I have a lot of dimensions that players use -_-' Turning off entity handling in the config should fix it until a fix is available right?

TerdyTheTerd commented 4 years ago

Not to necro-post, but I've been getting the same error as described here, specifically crashing when entering DIM20, aka The Between Lands `Description: Exception ticking world entities

java.util.ConcurrentModificationException: List modified before going to next entry at com.wildex999.tickdynamic.listinject.EntityIteratorTimed.next(EntityIteratorTimed.java:81) at com.wildex999.tickdynamic.listinject.EntityIteratorTimed.next(EntityIteratorTimed.java:17) at com.wildex999.tickdynamic.listinject.ListManagerEntities.get(ListManagerEntities.java:50) at com.wildex999.tickdynamic.listinject.ListManagerEntities.get(ListManagerEntities.java:9) at net.minecraft.world.World.func_72939_s(World.java:1742) at net.minecraft.world.WorldServer.func_72939_s(WorldServer.java:613) at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:767) at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:397) at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) at java.lang.Thread.run(Unknown Source)`

I tried setting TD to not run on this dim, but perhaps since that was after the crash or since it was when I teleported I need to clear the entity list first? (Not sure where TD stores this, in the level.dat?)