search

The-GNTL-Project / Exchange

https://exchange.gntl.co.uk
3 stars 0 forks source link

Fees being charged on orders rather than transactions #74

Closed ElectricDosh closed 2 years ago

ElectricDosh commented 3 years ago

Fees should be charged on the value of completed transactions at time of execution, not on the order value at the time the order is placed. Charging a full fee on a partially fulfilled order disincentivizes placing any order that risks not being completely filled, and imo will be highly off-putting to big money and small high-frequency traders alike.

ElectricDosh commented 3 years ago

My suggestion, in addition to fixing the above, would be to have a discount on fees for makers vs takers, so as to incentivize filling the order books.

tylerjohneddy commented 3 years ago

Once the update is live, please test and if happy close

ElectricDosh commented 3 years ago

Unsure if #77 is related, will leave open for now.

BKdilse commented 3 years ago

@ElectricDosh are you able to test this one out?

ElectricDosh commented 3 years ago

Yeah this looks good now, although the fee isn't included in the transaction history, is that right?

BKdilse commented 2 years ago

Would it be better to show the fee per trade in the history @tylerjohneddy ?

BKdilse commented 2 years ago

Tested successfully, Fees not being displayed is a separate issue.