Section 1 Review

[The-King-of-Toasters]

Section 1 is completed and ready for review. This issue is essentially a "code review" and discussion of problems I've encountered.

Linting

• se lint complains about adding nbsp's to chapters 1-{1,3,5,6,9,11}. I've tried adding them manually, but it still complains. Shouldn't this be something that se typogrify should do?
• The RAW images and their xmp files spit out errors as well. Since the xmps are generated by darktable, I'm leaving them as is.
• There are complaints about unused CSS selectors for letters. Should I leave them as is for now?

CSS

Letters

• The typography manual says to use a .signature class for letter signatures. I have instead used epub:type="z3998:signature". Looking at the manual again, it seems I should include z3998:sender as well. Can I use both?
• The dateline for letters in the book is set in a smaller font with padding at the bottom. Should I attempt to match this?

Semantics

• I may have gone too far in a few places... Should I continue packing everything with spans I should I relax?

... More to come

[acabal]

I'm not familiar with raw images or xmp files. However if a file can only be read by Darktable, then we should replace it with an open format or remove it, because not everyone is going to have purchased that software. Also you can remove .orig from the filenames.

Yes, remove unused CSS selectors.

If you mean nbsps before ampersands, check the typography manual. In cases where there are company names like "Hawkins & Harker" then we want an nbsp before the ampersand.

Please use .signature for now as that's the style in the manual. Later we will update it to z3998 but the entire corpus must be updated.

You can add padding to datelines but leave the font size the same.

In terms of semantics, my rule of thumb is that if we're using a tag already (like <i> or <blockquote>) then add semantics. Otherwise as you noticed, it's possible to go down a very deep rabbit hole. However, the book should be consistent in semantic use. If you've already started then it either has to be finished in that style, or we have to go back and remove semantics to make things consistent across the whole book.