search

The-Modular-Mind / oscelot

OSC Mapping module for VCV Rack
GNU General Public License v3.0
20 stars 1 forks source link

V2 crashing Rack #3

Closed pgatt closed 2 years ago

pgatt commented 2 years ago

Hi there,

Don't know if you want to know yet, but your V2 test build from the community forum crashes Rack on opening the module browser. On Mac here.

The-Modular-Mind commented 2 years ago

Hmm I haven't tested on mac. Does Midi-Map/Midi-Cat work fine for you

The-Modular-Mind commented 2 years ago

Also have you compiled plugins before? Could you try compiling it and see if the behavior still exists if so

vernaillen commented 2 years ago

I have the same issue on Mac. Also after compiling from the latest commit.

It seems to be a common thing on Mac with newly ported modules. There's this thread including links to the fix commits in the Delexander repo: https://github.com/Delexander/Volume1/issues/18#issuecomment-961646415 Maybe that's helpful?

I'm not a C++ developer myself, but I did manage to set up the build environment on Mac, so I can help you test if you want.

The-Modular-Mind commented 2 years ago

Ah great thank you, I don't have a personal macbook so I've been only compiling it on GitHub. I'll take a look at that thread and see if I can fix it later today. Thank you for your help

The-Modular-Mind commented 2 years ago

Ok I think I fixed it, can you please try when you get a chance: https://github.com/The-Modular-Mind/oscelot/releases/tag/latest

The-Modular-Mind commented 2 years ago

Actually I left some test code in and broke it, another version is building right now.

The-Modular-Mind commented 2 years ago

The fixed builds are now available: https://github.com/The-Modular-Mind/oscelot/releases/tag/latest

pgatt commented 2 years ago

Yeah that fix seems to have done it here.