The-Notebookinator / notebookinator

https://the-notebookinator.github.io/notebookinator/
The Unlicense
32 stars 6 forks source link

:sparkles: Plots and Pie Charts for Every Theme #33

Open BattleCh1cken opened 4 months ago

BattleCh1cken commented 4 months ago

Requested Feature

I propose that we add plots and pie charts to the other themes, in order to have them match the functionality of the Radial theme

Current Implementation

Currently only the Radial theme supports plots and pie charts. It wraps the CeTZ plotting API to make it less verbose, and customize it to look nice.

Motivation

It would be nice to have this functionality in all of the themes, as these tools are really useful to have natively.

(Optional) Possible Implementations and Alternatives

Right now the major obstacle is that we haven't found a way to reduce code duplication while implementing these new components. The decision matrices already suffer from this problem, and they abstract all of their calculations away to a helper function.

An approach we could take is to only change the colors between themes. This means that we could provide a generic plot and pie chart component, and then have a colors parameter, which each theme could override, and present as a component.