search

The-OpenROAD-Project / ORAssistant

OpenROAD's Chatbot Assistant
GNU General Public License v3.0
5 stars 2 forks source link

Feat: Mypy checks #15

Closed luarss closed 2 months ago

luarss commented 2 months ago

faiss.py is now passing mypy checks (minus two random missing variables?)

Please do the same for the rest of backend @palaniappan-r

Fixes #9

luarss commented 2 months ago

Is this done? @palaniappan-r

palaniappan-r commented 2 months ago

Hi @luarss

I was able to fix most errors, except this one,

backend/src/chains/base_chain.py:35: error: Missing named argument "client_options" for "ChatGoogleGenerativeAI"  [call-arg]
backend/src/chains/base_chain.py:35: error: Missing named argument "transport" for "ChatGoogleGenerativeAI"  [call-arg]
backend/src/chains/base_chain.py:35: error: Missing named argument "additional_headers" for "ChatGoogleGenerativeAI"  [call-arg]
backend/src/chains/base_chain.py:35: error: Missing named argument "client" for "ChatGoogleGenerativeAI"  [call-arg]
backend/src/chains/base_chain.py:35: error: Missing named argument "async_client" for "ChatGoogleGenerativeAI"  [call-arg]

This is being thrown as I'm not passing the some arguments when using the Gemini API (these args are optional anyway) For now, I've ignored this by adding disable_error_code = call-arg to the mypy config

luarss commented 2 months ago

LGTM